You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/03/06 23:44:47 UTC
[GitHub] [incubator-pinot] jackjlli opened a new pull request #5123: Fix
default value for no dictionary byte column
jackjlli opened a new pull request #5123: Fix default value for no dictionary byte column
URL: https://github.com/apache/incubator-pinot/pull/5123
This PR fixes default value for no dictionary byte column.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request
#5123: Fix default value for no dictionary byte column
Posted by GitBox <gi...@apache.org>.
mcvsubbu commented on a change in pull request #5123: Fix default value for no dictionary byte column
URL: https://github.com/apache/incubator-pinot/pull/5123#discussion_r389196290
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java
##########
@@ -208,7 +208,7 @@ public long getLatestIngestionTimestamp() {
// each forward index entry will contain a 4 byte dictionary ID
forwardIndexColumnSize = FieldSpec.DataType.INT.size();
int dictionaryColumnSize;
- if (dataType == FieldSpec.DataType.STRING) {
+ if (!isFixedWidthColumn) {
Review comment:
better switch the if/else.
also, good to add BYTES column in the schema for realtime test (can be another PR)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] jackjlli commented on issue #5123: Fix default
value for no dictionary byte column
Posted by GitBox <gi...@apache.org>.
jackjlli commented on issue #5123: Fix default value for no dictionary byte column
URL: https://github.com/apache/incubator-pinot/pull/5123#issuecomment-596018324
> Please change RawIndexConverter line 168 for the same issue
Good catch, updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] jackjlli merged pull request #5123: Fix default
value for dictionary byte column
Posted by GitBox <gi...@apache.org>.
jackjlli merged pull request #5123: Fix default value for dictionary byte column
URL: https://github.com/apache/incubator-pinot/pull/5123
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] codecov-io commented on issue #5123: Fix default
value for no dictionary byte column
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #5123: Fix default value for no dictionary byte column
URL: https://github.com/apache/incubator-pinot/pull/5123#issuecomment-596028266
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5123?src=pr&el=h1) Report
> Merging [#5123](https://codecov.io/gh/apache/incubator-pinot/pull/5123?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/91850cd68ec671028f31031c0fde7b32d519e99e?src=pr&el=desc) will **increase** coverage by `8.27%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/5123?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5123 +/- ##
============================================
+ Coverage 49.29% 57.57% +8.27%
Complexity 12 12
============================================
Files 1183 1183
Lines 62377 62377
Branches 9139 9139
============================================
+ Hits 30748 35911 +5163
+ Misses 29196 23817 -5379
- Partials 2433 2649 +216
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5123?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rg/apache/pinot/core/minion/RawIndexConverter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5123/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9taW5pb24vUmF3SW5kZXhDb252ZXJ0ZXIuamF2YQ==) | `62.5% <0%> (+62.5%)` | `0 <0> (ø)` | :arrow_down: |
| [.../core/indexsegment/mutable/MutableSegmentImpl.java](https://codecov.io/gh/apache/incubator-pinot/pull/5123/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pbmRleHNlZ21lbnQvbXV0YWJsZS9NdXRhYmxlU2VnbWVudEltcGwuamF2YQ==) | `76.22% <100%> (+13.38%)` | `0 <0> (ø)` | :arrow_down: |
| [...pql/parsers/PinotQuery2BrokerRequestConverter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5123/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9QaW5vdFF1ZXJ5MkJyb2tlclJlcXVlc3RDb252ZXJ0ZXIuamF2YQ==) | `88.07% <0%> (+0.45%)` | `0% <0%> (ø)` | :arrow_down: |
| [...ment/creator/impl/SegmentColumnarIndexCreator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5123/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2NyZWF0b3IvaW1wbC9TZWdtZW50Q29sdW1uYXJJbmRleENyZWF0b3IuamF2YQ==) | `88.25% <0%> (+0.75%)` | `0% <0%> (ø)` | :arrow_down: |
| [.../helix/core/realtime/SegmentCompletionManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5123/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlYWx0aW1lL1NlZ21lbnRDb21wbGV0aW9uTWFuYWdlci5qYXZh) | `70.63% <0%> (+0.85%)` | `0% <0%> (ø)` | :arrow_down: |
| [.../FixedByteSingleColumnSingleValueReaderWriter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5123/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pby9yZWFkZXJ3cml0ZXIvaW1wbC9GaXhlZEJ5dGVTaW5nbGVDb2x1bW5TaW5nbGVWYWx1ZVJlYWRlcldyaXRlci5qYXZh) | `98.94% <0%> (+1.05%)` | `0% <0%> (ø)` | :arrow_down: |
| [...t/common/response/broker/BrokerResponseNative.java](https://codecov.io/gh/apache/incubator-pinot/pull/5123/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVzcG9uc2UvYnJva2VyL0Jyb2tlclJlc3BvbnNlTmF0aXZlLmphdmE=) | `90.52% <0%> (+1.05%)` | `0% <0%> (ø)` | :arrow_down: |
| [...not/broker/broker/helix/ClusterChangeMediator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5123/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0NsdXN0ZXJDaGFuZ2VNZWRpYXRvci5qYXZh) | `74.72% <0%> (+1.09%)` | `0% <0%> (ø)` | :arrow_down: |
| [...e/io/writer/impl/MutableOffHeapByteArrayStore.java](https://codecov.io/gh/apache/incubator-pinot/pull/5123/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pby93cml0ZXIvaW1wbC9NdXRhYmxlT2ZmSGVhcEJ5dGVBcnJheVN0b3JlLmphdmE=) | `85.71% <0%> (+1.09%)` | `0% <0%> (ø)` | :arrow_down: |
| [.../pinot/broker/broker/helix/HelixBrokerStarter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5123/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0hlbGl4QnJva2VyU3RhcnRlci5qYXZh) | `71.97% <0%> (+1.27%)` | `0% <0%> (ø)` | :arrow_down: |
| ... and [304 more](https://codecov.io/gh/apache/incubator-pinot/pull/5123/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5123?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5123?src=pr&el=footer). Last update [91850cd...6792389](https://codecov.io/gh/apache/incubator-pinot/pull/5123?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] siddharthteotia commented on issue #5123: Fix
default value for no dictionary byte column
Posted by GitBox <gi...@apache.org>.
siddharthteotia commented on issue #5123: Fix default value for no dictionary byte column
URL: https://github.com/apache/incubator-pinot/pull/5123#issuecomment-596026560
@jlli, thanks for fixing this. I think the PR description is misleading. It is a dictionary column. Also I have an open PR for adding tests. https://github.com/apache/incubator-pinot/pull/5083 We can add more tests in that PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] siddharthteotia edited a comment on issue #5123:
Fix default value for no dictionary byte column
Posted by GitBox <gi...@apache.org>.
siddharthteotia edited a comment on issue #5123: Fix default value for no dictionary byte column
URL: https://github.com/apache/incubator-pinot/pull/5123#issuecomment-596026560
@jackjlli thanks for fixing this. I think the PR description is misleading. It is a dictionary column. Also I have an open PR for adding tests. https://github.com/apache/incubator-pinot/pull/5083 We can add more tests in that PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org