You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/11/05 03:23:03 UTC

[GitHub] [pulsar] sijie commented on a change in pull request #5491: Fix message deduplicate issue while using external sequence id with batch produce

sijie commented on a change in pull request #5491: Fix message deduplicate issue while using external sequence id with batch produce
URL: https://github.com/apache/pulsar/pull/5491#discussion_r342366937
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/BatchMessageContainerImpl.java
 ##########
 @@ -50,7 +50,8 @@
 
     private PulsarApi.MessageMetadata.Builder messageMetadata = PulsarApi.MessageMetadata.newBuilder();
     // sequence id for this batch which will be persisted as a single entry by broker
-    private long sequenceId = -1;
+    private long lowestSequenceId = -1;
+    private long highestSequenceId = -1;
 
 Review comment:
   ```suggestion
       private long highestSequenceId = -1L;
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services