You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by "empiredan (via GitHub)" <gi...@apache.org> on 2023/12/11 08:52:05 UTC

[PR] Add 2.5.0 release [incubator-pegasus-website]

empiredan opened a new pull request, #38:
URL: https://github.com/apache/incubator-pegasus-website/pull/38

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org


Re: [PR] Release 2.5.0 [incubator-pegasus-website]

Posted by "acelyc111 (via GitHub)" <gi...@apache.org>.
acelyc111 commented on code in PR #38:
URL: https://github.com/apache/incubator-pegasus-website/pull/38#discussion_r1422245865


##########
_docs/en/2.5.0/compile-by-docker.md:
##########
@@ -0,0 +1,73 @@
+---
+permalink: 2.5.0/docs/build/compile-by-docker/
+redirect_from:
+  - 2.5.0/docs/build/compile-by-docker/
+version: 2.5.0
+---
+
+## Download the docker image
+
+Pegasus encapsulates the building environments into [docker images](https://hub.docker.com/r/apache/pegasus/tags?page=1&name=env), you can build directly based on these environments.
+
+For example, you can use the image based on `Ubuntu 20.04`:
+```bash
+docker pull apache/pegasus:build-env-ubuntu2004
+```
+
+## Compilation
+
+Please refer to [Downloads](/docs/downloads) to fetch the sources under a directory (`/your/local/apache-pegasus-source`). Then run the following command:
+
+If you want to run tests, you should build Pegasus by the following command:
+
+```bash
+docker run -v /your/local/apache-pegasus-source:/root/pegasus \
+           apache/pegasus:build-env-ubuntu2004 \

Review Comment:
   Is there an image specified for 2.5.0? Because the images might have been updated(remove some packages), it may cause build failures.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org


Re: [PR] Release 2.5.0 [incubator-pegasus-website]

Posted by "empiredan (via GitHub)" <gi...@apache.org>.
empiredan commented on code in PR #38:
URL: https://github.com/apache/incubator-pegasus-website/pull/38#discussion_r1422428576


##########
_docs/en/2.5.0/compile-by-docker.md:
##########
@@ -0,0 +1,73 @@
+---
+permalink: 2.5.0/docs/build/compile-by-docker/
+redirect_from:
+  - 2.5.0/docs/build/compile-by-docker/
+version: 2.5.0
+---
+
+## Download the docker image
+
+Pegasus encapsulates the building environments into [docker images](https://hub.docker.com/r/apache/pegasus/tags?page=1&name=env), you can build directly based on these environments.
+
+For example, you can use the image based on `Ubuntu 20.04`:
+```bash
+docker pull apache/pegasus:build-env-ubuntu2004
+```
+
+## Compilation
+
+Please refer to [Downloads](/docs/downloads) to fetch the sources under a directory (`/your/local/apache-pegasus-source`). Then run the following command:
+
+If you want to run tests, you should build Pegasus by the following command:
+
+```bash
+docker run -v /your/local/apache-pegasus-source:/root/pegasus \
+           apache/pegasus:build-env-ubuntu2004 \

Review Comment:
   Good advice! I think we could modify [build-push-env-docker.yml](https://github.com/apache/incubator-pegasus/blob/master/.github/workflows/build-push-env-docker.yml) to support build-env images to different branches, such as master, v2.5.0, etc.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org


Re: [PR] Release 2.5.0 [incubator-pegasus-website]

Posted by "empiredan (via GitHub)" <gi...@apache.org>.
empiredan commented on PR #38:
URL: https://github.com/apache/incubator-pegasus-website/pull/38#issuecomment-1850225210

   > https://github.com/apache/incubator-pegasus-website/pull/38#discussion_r1422428576
   
   Building build-env-* images for different branches have been supported by:
   https://github.com/apache/incubator-pegasus/pull/1763


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org


Re: [PR] Release 2.5.0 [incubator-pegasus-website]

Posted by "empiredan (via GitHub)" <gi...@apache.org>.
empiredan commented on code in PR #38:
URL: https://github.com/apache/incubator-pegasus-website/pull/38#discussion_r1422428576


##########
_docs/en/2.5.0/compile-by-docker.md:
##########
@@ -0,0 +1,73 @@
+---
+permalink: 2.5.0/docs/build/compile-by-docker/
+redirect_from:
+  - 2.5.0/docs/build/compile-by-docker/
+version: 2.5.0
+---
+
+## Download the docker image
+
+Pegasus encapsulates the building environments into [docker images](https://hub.docker.com/r/apache/pegasus/tags?page=1&name=env), you can build directly based on these environments.
+
+For example, you can use the image based on `Ubuntu 20.04`:
+```bash
+docker pull apache/pegasus:build-env-ubuntu2004
+```
+
+## Compilation
+
+Please refer to [Downloads](/docs/downloads) to fetch the sources under a directory (`/your/local/apache-pegasus-source`). Then run the following command:
+
+If you want to run tests, you should build Pegasus by the following command:
+
+```bash
+docker run -v /your/local/apache-pegasus-source:/root/pegasus \
+           apache/pegasus:build-env-ubuntu2004 \

Review Comment:
   Good advice! I think we could modify [build-push-env-docker.yml](https://github.com/apache/incubator-pegasus/blob/master/.github/workflows/build-push-env-docker.yml) to support build-env-* images for different branches, such as master, v2.5.0, etc.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org


Re: [PR] Release 2.5.0 [incubator-pegasus-website]

Posted by "empiredan (via GitHub)" <gi...@apache.org>.
empiredan merged PR #38:
URL: https://github.com/apache/incubator-pegasus-website/pull/38


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org