You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/03/18 05:22:55 UTC

[GitHub] [solr] dsmiley opened a new pull request #750: SOLR-15223 BaseCloudSolrClient is the new CloudSolrClient

dsmiley opened a new pull request #750:
URL: https://github.com/apache/solr/pull/750


   https://issues.apache.org/jira/browse/SOLR-15223
   
   Look commit-by-commit to see what I did.
   
   CollectionsRepairEventListenerTest isn't happy but otherwise tests are green.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] dsmiley merged pull request #750: SOLR-15223 BaseCloudSolrClient is the new CloudSolrClient

Posted by GitBox <gi...@apache.org>.
dsmiley merged pull request #750:
URL: https://github.com/apache/solr/pull/750


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] dsmiley commented on pull request #750: SOLR-15223 BaseCloudSolrClient is the new CloudSolrClient

Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #750:
URL: https://github.com/apache/solr/pull/750#issuecomment-1078190099


   Thanks for looking carefully Christine!  I copied those javadocs directly from the Http2 one so that's how it got that way.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] janhoy commented on a change in pull request #750: SOLR-15223 BaseCloudSolrClient is the new CloudSolrClient

Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #750:
URL: https://github.com/apache/solr/pull/750#discussion_r829770160



##########
File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp1SolrClient.java
##########
@@ -0,0 +1,351 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.solr.client.solrj.impl;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import org.apache.http.NoHttpResponseException;
+import org.apache.http.client.HttpClient;
+import org.apache.http.conn.ConnectTimeoutException;
+import org.apache.solr.client.solrj.request.UpdateRequest;
+import org.apache.solr.common.SolrException;
+import org.apache.solr.common.cloud.DocCollection;
+import org.apache.solr.common.cloud.DocRouter;
+import org.apache.solr.common.params.ModifiableSolrParams;
+import org.apache.solr.common.util.NamedList;
+
+/**
+ * SolrJ client class to communicate with SolrCloud. Instances of this class communicate with
+ * Zookeeper to discover Solr endpoints for SolrCloud collections, and then use the {@link
+ * LBHttpSolrClient} to issue requests.
+ *
+ * @deprecated Please use {@link CloudHttp2SolrClient}

Review comment:
       Refer users to CloudSolrClient instead?

##########
File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java
##########
@@ -34,7 +34,7 @@
  * @since solr 8.0
  */
 @SuppressWarnings("serial")

Review comment:
       Should CloudHttp2SolrClient be deprecated and ask users to use CloudSolrClient? Hmm, that sounds confusing for those who moved from CloudSolrClient to CloudHttp2SolrClient in 8.x :) So perhaps a point to wait closer to 10.0 to explain this dance to users..




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] janhoy commented on a change in pull request #750: SOLR-15223 BaseCloudSolrClient is the new CloudSolrClient

Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #750:
URL: https://github.com/apache/solr/pull/750#discussion_r829770160



##########
File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp1SolrClient.java
##########
@@ -0,0 +1,351 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.solr.client.solrj.impl;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import org.apache.http.NoHttpResponseException;
+import org.apache.http.client.HttpClient;
+import org.apache.http.conn.ConnectTimeoutException;
+import org.apache.solr.client.solrj.request.UpdateRequest;
+import org.apache.solr.common.SolrException;
+import org.apache.solr.common.cloud.DocCollection;
+import org.apache.solr.common.cloud.DocRouter;
+import org.apache.solr.common.params.ModifiableSolrParams;
+import org.apache.solr.common.util.NamedList;
+
+/**
+ * SolrJ client class to communicate with SolrCloud. Instances of this class communicate with
+ * Zookeeper to discover Solr endpoints for SolrCloud collections, and then use the {@link
+ * LBHttpSolrClient} to issue requests.
+ *
+ * @deprecated Please use {@link CloudHttp2SolrClient}

Review comment:
       Refer users to CloudSolrClient instead?

##########
File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java
##########
@@ -34,7 +34,7 @@
  * @since solr 8.0
  */
 @SuppressWarnings("serial")

Review comment:
       Should CloudHttp2SolrClient be deprecated and ask users to use CloudSolrClient? Hmm, that sounds confusing for those who moved from CloudSolrClient to CloudHttp2SolrClient in 8.x :) So perhaps a point to wait closer to 10.0 to explain this dance to users..

##########
File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp1SolrClient.java
##########
@@ -0,0 +1,351 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.solr.client.solrj.impl;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import org.apache.http.NoHttpResponseException;
+import org.apache.http.client.HttpClient;
+import org.apache.http.conn.ConnectTimeoutException;
+import org.apache.solr.client.solrj.request.UpdateRequest;
+import org.apache.solr.common.SolrException;
+import org.apache.solr.common.cloud.DocCollection;
+import org.apache.solr.common.cloud.DocRouter;
+import org.apache.solr.common.params.ModifiableSolrParams;
+import org.apache.solr.common.util.NamedList;
+
+/**
+ * SolrJ client class to communicate with SolrCloud. Instances of this class communicate with
+ * Zookeeper to discover Solr endpoints for SolrCloud collections, and then use the {@link
+ * LBHttpSolrClient} to issue requests.
+ *
+ * @deprecated Please use {@link CloudHttp2SolrClient}
+ */
+@Deprecated(since = "9.0")
+public class CloudHttp1SolrClient extends CloudSolrClient {

Review comment:
       As you also noted, *Http1* here is misleading, since CloudHttp2SolrClient is *capable* of http2, but also of http1.
   
   Have you considered `CloudApacheHttpSolrClient` or similar to point to the fact that apache-http is used? Or if we want to hint that it is using `LBHttpSolrClient` and `HttpSolrClient` under the hood, the name should be simply `CloudHttpSolrClient` for a strong name-similarity?

##########
File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp1SolrClient.java
##########
@@ -0,0 +1,351 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.solr.client.solrj.impl;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import org.apache.http.NoHttpResponseException;
+import org.apache.http.client.HttpClient;
+import org.apache.http.conn.ConnectTimeoutException;
+import org.apache.solr.client.solrj.request.UpdateRequest;
+import org.apache.solr.common.SolrException;
+import org.apache.solr.common.cloud.DocCollection;
+import org.apache.solr.common.cloud.DocRouter;
+import org.apache.solr.common.params.ModifiableSolrParams;
+import org.apache.solr.common.util.NamedList;
+
+/**
+ * SolrJ client class to communicate with SolrCloud. Instances of this class communicate with
+ * Zookeeper to discover Solr endpoints for SolrCloud collections, and then use the {@link
+ * LBHttpSolrClient} to issue requests.
+ *
+ * @deprecated Please use {@link CloudHttp2SolrClient}
+ */
+@Deprecated(since = "9.0")
+public class CloudHttp1SolrClient extends CloudSolrClient {

Review comment:
       +1 to `CloudLegacySolrClient`, and it will be deprecated anyway so then both the name and the deprecation shouts don't use me if you don't have to :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] cpoerschke commented on a change in pull request #750: SOLR-15223 BaseCloudSolrClient is the new CloudSolrClient

Posted by GitBox <gi...@apache.org>.
cpoerschke commented on a change in pull request #750:
URL: https://github.com/apache/solr/pull/750#discussion_r834644743



##########
File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java
##########
@@ -230,122 +166,1272 @@ public Builder(ClusterStateProvider stateProvider) {
      * <pre>
      *   final List&lt;String&gt; zkServers = new ArrayList&lt;String&gt;();
      *   zkServers.add("zookeeper1:2181"); zkServers.add("zookeeper2:2181"); zkServers.add("zookeeper3:2181");
-     *   final SolrClient client = new CloudSolrClient.Builder(zkServers, Optional.empty()).build();
+     *   final SolrClient client = new CloudHttp2SolrClient.Builder(zkServers, Optional.empty()).build();
      * </pre>
      *
      * Usage example when Solr data is stored in a ZooKeeper chroot:
      *
      * <pre>
      *    final List&lt;String&gt; zkServers = new ArrayList&lt;String&gt;();
      *    zkServers.add("zookeeper1:2181"); zkServers.add("zookeeper2:2181"); zkServers.add("zookeeper3:2181");
-     *    final SolrClient client = new CloudSolrClient.Builder(zkServers, Optional.of("/solr")).build();
+     *    final SolrClient client = new CloudHttp2SolrClient.Builder(zkServers, Optional.of("/solr")).build();

Review comment:
       ```suggestion
        *    final SolrClient client = new CloudSolrClient.Builder(zkServers, Optional.of("/solr")).build();
   ```

##########
File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java
##########
@@ -209,16 +150,11 @@ protected Builder() {}
      * <pre>
      *   final List&lt;String&gt; solrBaseUrls = new ArrayList&lt;String&gt;();
      *   solrBaseUrls.add("http://solr1:8983/solr"); solrBaseUrls.add("http://solr2:8983/solr"); solrBaseUrls.add("http://solr3:8983/solr");
-     *   final SolrClient client = new CloudSolrClient.Builder(solrBaseUrls).build();
+     *   final SolrClient client = new CloudHttp2SolrClient.Builder(solrBaseUrls).build();

Review comment:
       ```suggestion
        *   final SolrClient client = new CloudSolrClient.Builder(solrBaseUrls).build();
   ```

##########
File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java
##########
@@ -230,122 +166,1272 @@ public Builder(ClusterStateProvider stateProvider) {
      * <pre>
      *   final List&lt;String&gt; zkServers = new ArrayList&lt;String&gt;();
      *   zkServers.add("zookeeper1:2181"); zkServers.add("zookeeper2:2181"); zkServers.add("zookeeper3:2181");
-     *   final SolrClient client = new CloudSolrClient.Builder(zkServers, Optional.empty()).build();
+     *   final SolrClient client = new CloudHttp2SolrClient.Builder(zkServers, Optional.empty()).build();

Review comment:
       ```suggestion
        *   final SolrClient client = new CloudSolrClient.Builder(zkServers, Optional.empty()).build();
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] dsmiley commented on a change in pull request #750: SOLR-15223 BaseCloudSolrClient is the new CloudSolrClient

Posted by GitBox <gi...@apache.org>.
dsmiley commented on a change in pull request #750:
URL: https://github.com/apache/solr/pull/750#discussion_r829965942



##########
File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp1SolrClient.java
##########
@@ -0,0 +1,351 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.solr.client.solrj.impl;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import org.apache.http.NoHttpResponseException;
+import org.apache.http.client.HttpClient;
+import org.apache.http.conn.ConnectTimeoutException;
+import org.apache.solr.client.solrj.request.UpdateRequest;
+import org.apache.solr.common.SolrException;
+import org.apache.solr.common.cloud.DocCollection;
+import org.apache.solr.common.cloud.DocRouter;
+import org.apache.solr.common.params.ModifiableSolrParams;
+import org.apache.solr.common.util.NamedList;
+
+/**
+ * SolrJ client class to communicate with SolrCloud. Instances of this class communicate with
+ * Zookeeper to discover Solr endpoints for SolrCloud collections, and then use the {@link
+ * LBHttpSolrClient} to issue requests.
+ *
+ * @deprecated Please use {@link CloudHttp2SolrClient}
+ */
+@Deprecated(since = "9.0")
+public class CloudHttp1SolrClient extends CloudSolrClient {

Review comment:
       Indeed I've thought of this but stopped short because we hadn't discussed it yet.  Indeed, I would prefer a name like CloudApacheHttpSolrClient or CloudLegacySolrClient.  I'll raise this in the list for visibility.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] janhoy commented on pull request #750: SOLR-15223 BaseCloudSolrClient is the new CloudSolrClient

Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #750:
URL: https://github.com/apache/solr/pull/750#issuecomment-1076393125


   Brought the branch up to date and fixed spotless.
   
   Beware of re-organization of 9.0 CHANGES section in #754 that may or may affect this during merge, depending on which is merged first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] janhoy commented on a change in pull request #750: SOLR-15223 BaseCloudSolrClient is the new CloudSolrClient

Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #750:
URL: https://github.com/apache/solr/pull/750#discussion_r829808444



##########
File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp1SolrClient.java
##########
@@ -0,0 +1,351 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.solr.client.solrj.impl;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import org.apache.http.NoHttpResponseException;
+import org.apache.http.client.HttpClient;
+import org.apache.http.conn.ConnectTimeoutException;
+import org.apache.solr.client.solrj.request.UpdateRequest;
+import org.apache.solr.common.SolrException;
+import org.apache.solr.common.cloud.DocCollection;
+import org.apache.solr.common.cloud.DocRouter;
+import org.apache.solr.common.params.ModifiableSolrParams;
+import org.apache.solr.common.util.NamedList;
+
+/**
+ * SolrJ client class to communicate with SolrCloud. Instances of this class communicate with
+ * Zookeeper to discover Solr endpoints for SolrCloud collections, and then use the {@link
+ * LBHttpSolrClient} to issue requests.
+ *
+ * @deprecated Please use {@link CloudHttp2SolrClient}
+ */
+@Deprecated(since = "9.0")
+public class CloudHttp1SolrClient extends CloudSolrClient {

Review comment:
       As you also noted, *Http1* here is misleading, since CloudHttp2SolrClient is *capable* of http2, but also of http1.
   
   Have you considered `CloudApacheHttpSolrClient` or similar to point to the fact that apache-http is used? Or if we want to hint that it is using `LBHttpSolrClient` and `HttpSolrClient` under the hood, the name should be simply `CloudHttpSolrClient` for a strong name-similarity?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] dsmiley commented on a change in pull request #750: SOLR-15223 BaseCloudSolrClient is the new CloudSolrClient

Posted by GitBox <gi...@apache.org>.
dsmiley commented on a change in pull request #750:
URL: https://github.com/apache/solr/pull/750#discussion_r829970588



##########
File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java
##########
@@ -34,7 +34,7 @@
  * @since solr 8.0
  */
 @SuppressWarnings("serial")

Review comment:
       Yeah; makes sense to wait.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] dsmiley commented on a change in pull request #750: SOLR-15223 BaseCloudSolrClient is the new CloudSolrClient

Posted by GitBox <gi...@apache.org>.
dsmiley commented on a change in pull request #750:
URL: https://github.com/apache/solr/pull/750#discussion_r829965942



##########
File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp1SolrClient.java
##########
@@ -0,0 +1,351 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.solr.client.solrj.impl;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import org.apache.http.NoHttpResponseException;
+import org.apache.http.client.HttpClient;
+import org.apache.http.conn.ConnectTimeoutException;
+import org.apache.solr.client.solrj.request.UpdateRequest;
+import org.apache.solr.common.SolrException;
+import org.apache.solr.common.cloud.DocCollection;
+import org.apache.solr.common.cloud.DocRouter;
+import org.apache.solr.common.params.ModifiableSolrParams;
+import org.apache.solr.common.util.NamedList;
+
+/**
+ * SolrJ client class to communicate with SolrCloud. Instances of this class communicate with
+ * Zookeeper to discover Solr endpoints for SolrCloud collections, and then use the {@link
+ * LBHttpSolrClient} to issue requests.
+ *
+ * @deprecated Please use {@link CloudHttp2SolrClient}
+ */
+@Deprecated(since = "9.0")
+public class CloudHttp1SolrClient extends CloudSolrClient {

Review comment:
       Indeed I've thought of this but stopped short because we hadn't discussed it yet.  Indeed, I would prefer a name like CloudApacheHttpSolrClient or CloudLegacySolrClient.  I'll raise this in the list for visibility.

##########
File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java
##########
@@ -34,7 +34,7 @@
  * @since solr 8.0
  */
 @SuppressWarnings("serial")

Review comment:
       Yeah; makes sense to wait.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org