[GitHub] [pinot] kishoreg commented on pull request #7820: push JSON Path evaluation down to storage layer

[GitBox <gi...@apache.org>]

kishoreg commented on pull request #7820:
URL: https://github.com/apache/pinot/pull/7820#issuecomment-983856821


   Thanks @richardstartin. I did pull the branch and reviewed the code. Given the state of the current code, I think what you have done is probably the least invasive change. I will list my wishful state to get to here
   ```
   public interface ForwardIndexReader<T extends ForwardIndexReaderContext> extends Closeable {
   
     boolean isNested();
   
     boolean isStructured();
   
     List<String> getNestedFields();
   
     ForwardIndexReader<T> getReader(String nestedField); or 
     ForwardIndexReader<T> getReader(Extractor/Evaluator e); or
     ForwardIndexReader<T> getReader(Function pushDownFunction); or
     ForwardIndexReader<T> getReader(Selector selector); or
   }
   ```
   
   But passing parameters down the Block abstraction is non-trivial given the state of the current code. 
   
   One request from my side would be to add javadoc the newly added methods with the evaluator as Beta that we will mark it stable once we get everything working end to end.
   
   Thanks again for taking the time to explain 
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org