You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by "David Mollitor (Jira)" <ji...@apache.org> on 2021/07/09 16:30:00 UTC

[jira] [Created] (ORC-840) Remove Superfluous Array Fill in RecordReaderImpl

David Mollitor created ORC-840:
----------------------------------

             Summary: Remove Superfluous Array Fill in RecordReaderImpl
                 Key: ORC-840
                 URL: https://issues.apache.org/jira/browse/ORC-840
             Project: ORC
          Issue Type: Improvement
            Reporter: David Mollitor
            Assignee: David Mollitor


{code:java}
public static int[] mapSargColumnsToOrcInternalColIdx(
                            List<PredicateLeaf> sargLeaves,
                            SchemaEvolution evolution) {
    int[] result = new int[sargLeaves.size()];
    Arrays.fill(result, -1);
    for(int i=0; i < result.length; ++i) {
      String colName = sargLeaves.get(i).getColumnName();
      result[i] = findColumns(evolution, colName);
    }
    return result;
  }
{code}

There is no reason here to pre-populate {{result}} with -1 values.  They are promptly overwritten in the following loop.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)