You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/11/07 22:02:00 UTC
[jira] [Commented] (NIFI-5800) If RecordSchema has an inner field
that references a schema recursively by name, hashCode() throws
StackOverflowError
[ https://issues.apache.org/jira/browse/NIFI-5800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678845#comment-16678845 ]
ASF GitHub Bot commented on NIFI-5800:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/3157
NIFI-5800: Do not recursively call hashCode on child schema for Recor…
…d Field Types
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-5800
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/3157.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3157
----
commit 111daf241d867ef7624a7f7304d286fce43bbacb
Author: Mark Payne <ma...@...>
Date: 2018-11-07T22:00:51Z
NIFI-5800: Do not recursively call hashCode on child schema for Record Field Types
----
> If RecordSchema has an inner field that references a schema recursively by name, hashCode() throws StackOverflowError
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: NIFI-5800
> URL: https://issues.apache.org/jira/browse/NIFI-5800
> Project: Apache NiFi
> Issue Type: Bug
> Reporter: Mark Payne
> Priority: Major
>
> If we have a schema where a field is of type RECORD and references an outer-level schema, we get StackOverflowError. For example:
> {
> "name": "person",
> "namespace": "nifi",
> "type": "record",
> "fields": [
> { "name": "name", "type": "string" },
> { "name": "mother", "type": "person" }
> ]
> }
> In this case, if we attempt to add this schema to a HashMap, we get the following error:
> 2018-11-07 19:09:33,021 ERROR [Timer-Driven Process Thread-38] o.a.n.p.k.pubsub.ConsumeKafkaRecord_2_0 ConsumeKafkaRecord_2_0[id=ef6bd50b-0166-1000-ffff-fffff55a7995] Exception while processing data from kafka so will close the lease org.apache.nifi.processors.kafka.pubsub.ConsumerPool$SimpleConsumerLease@26706081 due to java.lang.StackOverflowError: java.lang.StackOverflowError
> java.lang.StackOverflowError: null
> at java.util.AbstractList.hashCode(AbstractList.java:540)
> at java.util.Collections$UnmodifiableList.hashCode(Collections.java:1307)
> at org.apache.nifi.serialization.SimpleRecordSchema.hashCode(SimpleRecordSchema.java:172)
> at org.apache.nifi.serialization.record.type.RecordDataType.hashCode(RecordDataType.java:45)
> at org.apache.nifi.serialization.record.type.ArrayDataType.hashCode(ArrayDataType.java:44)
> at org.apache.nifi.serialization.record.RecordField.hashCode(RecordField.java:108)
> at java.util.AbstractList.hashCode(AbstractList.java:541)
> at java.util.Collections$UnmodifiableList.hashCode(Collections.java:1307)
> at org.apache.nifi.serialization.SimpleRecordSchema.hashCode(SimpleRecordSchema.java:172)
> at org.apache.nifi.serialization.record.type.RecordDataType.hashCode(RecordDataType.java:45)
> at org.apache.nifi.serialization.record.type.ArrayDataType.hashCode(ArrayDataType.java:44)
> at org.apache.nifi.serialization.record.RecordField.hashCode(RecordField.java:108)
> at java.util.AbstractList.hashCode(AbstractList.java:541)
> at java.util.Collections$UnmodifiableList.hashCode(Collections.java:1307)
> at org.apache.nifi.serialization.SimpleRecordSchema.hashCode(SimpleRecordSchema.java:172)
> at org.apache.nifi.serialization.record.type.RecordDataType.hashCode(RecordDataType.java:45)
> at org.apache.nifi.serialization.record.type.ArrayDataType.hashCode(ArrayDataType.java:44)
> at org.apache.nifi.serialization.record.RecordField.hashCode(RecordField.java:108)
> at java.util.AbstractList.hashCode(AbstractList.java:541)
> at java.util.Collections$UnmodifiableList.hashCode(Collections.java:1307)
> at org.apache.nifi.serialization.SimpleRecordSchema.hashCode(SimpleRecordSchema.java:172)
> at org.apache.nifi.serialization.record.type.RecordDataType.hashCode(RecordDataType.java:45)
> at org.apache.nifi.serialization.record.type.ArrayDataType.hashCode(ArrayDataType.java:44)
> at org.apache.nifi.serialization.record.RecordField.hashCode(RecordField.java:108)
> at java.util.AbstractList.hashCode(AbstractList.java:541)
> at java.util.Collections$UnmodifiableList.hashCode(Collections.java:1307)
> at org.apache.nifi.serialization.SimpleRecordSchema.hashCode(SimpleRecordSchema.java:172)
> at org.apache.nifi.serialization.record.type.RecordDataType.hashCode(RecordDataType.java:45)
> at org.apache.nifi.serialization.record.type.ArrayDataType.hashCode(ArrayDataType.java:44)
> at org.apache.nifi.serialization.record.RecordField.hashCode(RecordField.java:108)
> at java.util.AbstractList.hashCode(AbstractList.java:541)
> at java.util.Collections$UnmodifiableList.hashCode(Collections.java:1307)
> ...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)