You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/05/17 03:59:42 UTC
[GitHub] [cloudstack-cloudmonkey] Pearl1594 opened a new pull request #79: Validate arguments passed while setting configuration
Pearl1594 opened a new pull request #79:
URL: https://github.com/apache/cloudstack-cloudmonkey/pull/79
Fixes: https://github.com/apache/cloudstack-cloudmonkey/issues/77
Post Fix:
```
go run cmk.go -o default
Invalid value set for output format. Supported values: column,csv,json,table,text
exit status 1
$ go run cmk.go
Apache CloudStack 🐵 CloudMonkey 6.1.0
Report issues: https://github.com/apache/cloudstack-cloudmonkey/issues
(localcloud) 🐱 > set display default
🙈 Error: Invalid value set for output. Supported values: column, csv, json, table, text
(localcloud) 🐱 >
(localcloud) 🐱 > set output default
🙈 Error: Invalid value set for output. Supported values: column, csv, json, table, text
(localcloud) 🐱 >
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-cloudmonkey] rhtyd commented on a change in pull request #79: Validate arguments passed while setting configuration
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #79:
URL: https://github.com/apache/cloudstack-cloudmonkey/pull/79#discussion_r633449464
##########
File path: config/config.go
##########
@@ -74,6 +74,18 @@ type Config struct {
ActiveProfile *ServerProfile
}
+func GetOutputFormats() []string {
+ return []string {"column", "csv", "json", "table", "text"}
+}
+
+func CheckIfValuePresent(dataset []string, element string) bool {
Review comment:
thnx, I would have loved if Go had a std library method for this. :facepalm:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-cloudmonkey] rhtyd merged pull request #79: Validate arguments passed while setting configuration
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #79:
URL: https://github.com/apache/cloudstack-cloudmonkey/pull/79
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-cloudmonkey] rhtyd commented on a change in pull request #79: Validate arguments passed while setting configuration
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #79:
URL: https://github.com/apache/cloudstack-cloudmonkey/pull/79#discussion_r633449464
##########
File path: config/config.go
##########
@@ -74,6 +74,18 @@ type Config struct {
ActiveProfile *ServerProfile
}
+func GetOutputFormats() []string {
+ return []string {"column", "csv", "json", "table", "text"}
+}
+
+func CheckIfValuePresent(dataset []string, element string) bool {
Review comment:
thnx, I would have loved if Go had a std library method for this. :facepalm:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-cloudmonkey] Pearl1594 commented on pull request #79: Validate arguments passed while setting configuration
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #79:
URL: https://github.com/apache/cloudstack-cloudmonkey/pull/79#issuecomment-878820097
@andrijapanicsb Can you please help review/test this. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org