You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by revans2 <gi...@git.apache.org> on 2016/11/22 19:51:25 UTC
[GitHub] storm pull request #1795: STORM-2215: validate blobs are present before subm...
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/1795
STORM-2215: validate blobs are present before submitting
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-2215
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1795.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1795
----
commit d3b01c445d9a70bcc6edad93a5c4003ee9c66b82
Author: Robert (Bobby) Evans <ev...@yahoo-inc.com>
Date: 2016-11-22T19:50:41Z
STORM-2215: validate blobs are present before submitting
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1795: STORM-2215: validate blobs are present before submitting
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1795
@HeartSaVioR I rebased and addressed the review comments, but I want to merge in #1744 first and then I will update this one again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1795: STORM-2215: validate blobs are present before submitting
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1795
#1744 is in and this is rebased
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1795: STORM-2215: validate blobs are present before subm...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1795#discussion_r89416093
--- Diff: storm-core/src/jvm/org/apache/storm/StormSubmitter.java ---
@@ -587,4 +592,10 @@ private static double getMaxExecutorMemoryUsageForTopo(StormTopology topology, M
}
return largestMemoryOperator;
}
+
+ private static Set<String> getListOfKeysFromBlobStore(Map<String, Object> stormConf) {
+ NimbusBlobStore client = new NimbusBlobStore();
--- End diff --
Need to guarantee calling client.shutdown().
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1795: STORM-2215: validate blobs are present before subm...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1795#discussion_r89416315
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1338,6 +1339,26 @@ public static void handleUncaughtException(Throwable t) {
}
}
+ public static void validateTopologyBlobStoreMap(Map stormConf, Set<String> blobStoreKeys) throws InvalidTopologyException {
+ boolean containsAllBlobs = true;
--- End diff --
Minor: We're adding missing keys to Set so no need to have additional flag. `missingKeys.size() > 0` is same to `containsAllBlobs == false`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1795: STORM-2215: validate blobs are present before subm...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1795
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1795: STORM-2215: validate blobs are present before submitting
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1795
+1 Thanks for the work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---