You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/06 07:38:02 UTC

[GitHub] [spark] bjornjorgensen opened a new pull request, #36465: [SPARK-39113] Rename `self` to `cls` in mllib/clustering

bjornjorgensen opened a new pull request, #36465:
URL: https://github.com/apache/spark/pull/36465

   ### What changes were proposed in this pull request?
   Rename `self` to `cls`
   
   
   ### Why are the changes needed?
   Function def train(self....) is decorated as a @classmethod
   
   
   
   ### Does this PR introduce _any_ user-facing change?
   No.
   
   
   ### How was this patch tested?
   Pass existed tests.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] bjornjorgensen commented on pull request #36465: [SPARK-39113][CORE][MLLIB][PYTHON] Rename `self` to `cls`

Posted by GitBox <gi...@apache.org>.
bjornjorgensen commented on PR #36465:
URL: https://github.com/apache/spark/pull/36465#issuecomment-1120214437

   Thank you @Yikun 
   What tool are you using? 
   
   @srowen Not that I can find. 
   
   I`m using [sonarqube](https://sonar-spark.duckdns.org) but I can`t search after only this one thing. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen commented on pull request #36465: [SPARK-39113][CORE][MLLIB][PYTHON] Rename `self` to `cls`

Posted by GitBox <gi...@apache.org>.
srowen commented on PR #36465:
URL: https://github.com/apache/spark/pull/36465#issuecomment-1120211647

   Are there any other cases?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen commented on pull request #36465: [SPARK-39113][CORE][MLLIB][PYTHON] Rename `self` to `cls`

Posted by GitBox <gi...@apache.org>.
srowen commented on PR #36465:
URL: https://github.com/apache/spark/pull/36465#issuecomment-1120415891

   Merged to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] Yikun commented on pull request #36465: [SPARK-39113][CORE][MLLIB][PYTHON] Rename `self` to `cls` in mllib/clustering

Posted by GitBox <gi...@apache.org>.
Yikun commented on PR #36465:
URL: https://github.com/apache/spark/pull/36465#issuecomment-1120110145

    I'm fine with it. This is not mandatory but it's suggestion from pep8.
   
   [1] https://peps.python.org/pep-0008/#function-and-method-arguments
   
   ```
   # grep -R "@classmethod" **/*.py -A2 | grep self
   python/pyspark/mllib/clustering.py-        self,
   python/pyspark/testing/sqlutils.py-    def sqlType(self):
   python/pyspark/testing/sqlutils.py-    def sqlType(self):
   ```
   
   Then, let's also fix other style error together.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #36465: [SPARK-39113][CORE][MLLIB][PYTHON] Rename `self` to `cls` in mllib/clustering

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #36465:
URL: https://github.com/apache/spark/pull/36465#issuecomment-1119349929

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] Yikun commented on pull request #36465: [SPARK-39113][CORE][MLLIB][PYTHON] Rename `self` to `cls`

Posted by GitBox <gi...@apache.org>.
Yikun commented on PR #36465:
URL: https://github.com/apache/spark/pull/36465#issuecomment-1120216408

   @bjornjorgensen No tool in here, just a script as I mentioned in last comment: `grep -R "@classmethod" **/*.py -A2 | grep self`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen closed pull request #36465: [SPARK-39113][CORE][MLLIB][PYTHON] Rename `self` to `cls`

Posted by GitBox <gi...@apache.org>.
srowen closed pull request #36465: [SPARK-39113][CORE][MLLIB][PYTHON] Rename `self` to `cls`
URL: https://github.com/apache/spark/pull/36465


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org