You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ayanampudi Varsha <av...@us.ibm.com> on 2016/12/28 08:24:48 UTC

Review Request 55065: Added support for s390x architecture

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55065/
-----------------------------------------------------------

Review request for mesos.


Bugs: MESOS-6742
    https://issues.apache.org/jira/browse/MESOS-6742


Repository: mesos


Description
-------

Added support for s390x architecture
There are 2 issues addressed in this patch:
1. LdcacheTest.Parse test case fails on s390x machines.
2. From the value of flag docker_registry in slave/flags.cpp, amd64 images get downloaded due to which test cases fail on s390x with "Exec format Error"


Diffs
-----

  src/linux/ldcache.cpp 6260496672cd0226a24ea1b34003a48af9678a63 
  src/slave/flags.cpp 1eccea920338032173be4df6c374ec50dbd2eaf3 

Diff: https://reviews.apache.org/r/55065/diff/


Testing
-------


Thanks,

Ayanampudi Varsha

Re: Review Request 55065: Added support for s390x architecture

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55065/#review160273
-----------------------------------------------------------



Bad review!

Reviews applied: []

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.

- Mesos ReviewBot


On Dec. 28, 2016, 8:24 a.m., Ayanampudi Varsha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55065/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2016, 8:24 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-6742
>     https://issues.apache.org/jira/browse/MESOS-6742
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added support for s390x architecture
> There are 2 issues addressed in this patch:
> 1. LdcacheTest.Parse test case fails on s390x machines.
> 2. From the value of flag docker_registry in slave/flags.cpp, amd64 images get downloaded due to which test cases fail on s390x with "Exec format Error"
> 
> 
> Diffs
> -----
> 
>   src/linux/ldcache.cpp 6260496672cd0226a24ea1b34003a48af9678a63 
>   src/slave/flags.cpp 1eccea920338032173be4df6c374ec50dbd2eaf3 
> 
> Diff: https://reviews.apache.org/r/55065/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ayanampudi Varsha
> 
>