You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by davidbz <gi...@git.apache.org> on 2016/06/14 18:47:11 UTC
[GitHub] trafficserver pull request #712: TS-4523
GitHub user davidbz opened a pull request:
https://github.com/apache/trafficserver/pull/712
TS-4523
Adding the pause functionality to the TransformationPlugin.
Api changes:
Added the pause() method to the TransformationPlugin, the return value is a TSCont which you can schedule whenever you wish to resume the transformation.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/davidbz/trafficserver TS-4523
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/712.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #712
----
commit ca61aa0b7f117e691520a214a7e70b31248b828a
Author: David Ben Zakai <da...@gmail.com>
Date: 2016-06-14T08:59:10Z
TS-4523
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #712: TS-4523
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/712
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #712: TS-4523
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/712
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/185/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #712: TS-4523 - Add pause functionality to the Transform...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/712
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/929/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #712: TS-4523
Posted by ushachar <gi...@git.apache.org>.
Github user ushachar commented on the issue:
https://github.com/apache/trafficserver/pull/712
Yep. Getting back to this asap....
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #712: TS-4523
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/712
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/293/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #712: TS-4523
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/712
Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/165/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #712: TS-4523
Posted by davidbz <gi...@git.apache.org>.
Github user davidbz commented on the issue:
https://github.com/apache/trafficserver/pull/712
@zwoop - Thanks! it seems to work just fine on my machine.. still trying to figure it out
@ushachar - Done! thanks..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #712: TS-4523
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/712
Some minor details here:
1) Update the commit subject message please.
2) It now has marge conflicts, so please rebase, and re-run clang-format as well.
@ushachar Can you help land this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #712: TS-4523
Posted by ushachar <gi...@git.apache.org>.
Github user ushachar commented on the issue:
https://github.com/apache/trafficserver/pull/712
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #712: TS-4523 - Add pause functionality to the Transform...
Posted by ushachar <gi...@git.apache.org>.
Github user ushachar commented on the issue:
https://github.com/apache/trafficserver/pull/712
@jpeach / @SolidWallOfCode - Since there were a couple of concerns about this API in the beginning could one of you ack this as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #712: TS-4523
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/712
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/271/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #712: TS-4523 - Add pause functionality to the Transform...
Posted by ushachar <gi...@git.apache.org>.
Github user ushachar commented on the issue:
https://github.com/apache/trafficserver/pull/712
The reason for wanting this feature is to support prolonged content related actions -- in @davidbz case out-of-process content malware analysis.
When acting as a forward proxy and handling a request for a very large file, he needs to support an initial analysis on the first N MBs of the file in order to decide if he must analyze the full file or can release it to the client.
This analysis can take a significant amount of time and continuing to buffer the contents can lead to resource exhaustion.
(When combined with turning on flow control to make sure that we throttle the proxy<->upstream tcp connection)
@bgaff - I know you had some concerns regarding this - does this use case seem reasonable to you?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #712: TS-4523
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/712
Remember to run clang-format on any contribution :) It's easiest done with a simple
make clang-format
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #712: TS-4523 - Add pause functionality to the Transform...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/712
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/823/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #712: TS-4523 - Add pause functionality to the Transform...
Posted by ushachar <gi...@git.apache.org>.
Github user ushachar commented on the issue:
https://github.com/apache/trafficserver/pull/712
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #712: TS-4523 - Add pause functionality to the Transform...
Posted by davidbz <gi...@git.apache.org>.
Github user davidbz commented on the issue:
https://github.com/apache/trafficserver/pull/712
@ushachar Done. Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---