You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hugegraph.apache.org by "Z-HUANT (via GitHub)" <gi...@apache.org> on 2023/07/17 14:04:15 UTC
[GitHub] [incubator-hugegraph] Z-HUANT opened a new pull request, #2247: fix：asf invalid notification scheme 'discussions_status'
Z-HUANT opened a new pull request, #2247:
URL: https://github.com/apache/incubator-hugegraph/pull/2247
## Purpose of the PR
Error while running notifications feature from .asf.yaml in incubator-hugegraph!
## Main Changes
fix：asf invalid notification scheme 'discussions_status'
## Verifying these changes
- [ ] Trivial rework / code cleanup without any test coverage. (No Need)
- [ ] Already covered by existing tests, such as *(please modify tests here)*.
- [ ] Need tests and can be verified as follows:
## Does this PR potentially affect the following parts?
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] Nope
- [ ] Dependencies (add/update license info) <!-- Don't forget to add/update the info in "LICENSE" & "NOTICE" files (both in root & dist module) -->
- [ ] Modify configurations
- [ ] The public API
- [x] Other affects (typed here)
fix：asf invalid notification scheme 'discussions_status'
## Documentation Status
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `Doc - TODO` <!-- Your PR changes impact docs and you will update later -->
- [ ] `Doc - Done` <!-- Related docs have been already added or updated -->
- [x] `Doc - No Need` <!-- Your PR changes don't impact/need docs -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph] codecov[bot] commented on pull request #2247: fix：asf invalid notification scheme 'discussions_status'
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2247:
URL: https://github.com/apache/incubator-hugegraph/pull/2247#issuecomment-1638241801
## [Codecov](https://app.codecov.io/gh/apache/incubator-hugegraph/pull/2247?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#2247](https://app.codecov.io/gh/apache/incubator-hugegraph/pull/2247?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (e4e2822) into [master](https://app.codecov.io/gh/apache/incubator-hugegraph/commit/8ee3d32b4ffcb6b27d6d5762783039866c0a9147?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (8ee3d32) will **decrease** coverage by `16.53%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #2247 +/- ##
=============================================
- Coverage 65.03% 48.51% -16.53%
+ Complexity 979 378 -601
=============================================
Files 498 498
Lines 40682 40684 +2
Branches 5681 5681
=============================================
- Hits 26458 19738 -6720
- Misses 11596 18810 +7214
+ Partials 2628 2136 -492
```
[see 164 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-hugegraph/pull/2247/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph] Z-HUANT commented on a diff in pull request #2247: fix：asf invalid notification scheme 'discussions_status'
Posted by "Z-HUANT (via GitHub)" <gi...@apache.org>.
Z-HUANT commented on code in PR #2247:
URL: https://github.com/apache/incubator-hugegraph/pull/2247#discussion_r1269045076
##########
.asf.yaml:
##########
@@ -57,5 +57,5 @@ notifications:
issues: issues@hugegraph.apache.org
issues_status: dev@hugegraph.apache.org
issues_comment: issues@hugegraph.apache.org
- discussions_status: dev@hugegraph.apache.org
+ discussions: dev@hugegraph.apache.org
discussions_comment: issues@hugegraph.apache.org
Review Comment:
> @Z-HUANT`discussions_comment`对于同样的问题，我们还需要删除
Pull request has been submitted. https://github.com/apache/incubator-hugegraph/pull/2250
##########
.asf.yaml:
##########
@@ -57,5 +57,5 @@ notifications:
issues: issues@hugegraph.apache.org
issues_status: dev@hugegraph.apache.org
issues_comment: issues@hugegraph.apache.org
- discussions_status: dev@hugegraph.apache.org
+ discussions: dev@hugegraph.apache.org
discussions_comment: issues@hugegraph.apache.org
Review Comment:
> @Z-HUANT`discussions_comment`对于同样的问题，我们还需要删除
Pull request has been submitted. https://github.com/apache/incubator-hugegraph/pull/2250
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph] imbajin merged pull request #2247: fix：asf invalid notification scheme 'discussions_status'
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin merged PR #2247:
URL: https://github.com/apache/incubator-hugegraph/pull/2247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph] imbajin commented on a diff in pull request #2247: fix：asf invalid notification scheme 'discussions_status'
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on code in PR #2247:
URL: https://github.com/apache/incubator-hugegraph/pull/2247#discussion_r1268999323
##########
.asf.yaml:
##########
@@ -57,5 +57,5 @@ notifications:
issues: issues@hugegraph.apache.org
issues_status: dev@hugegraph.apache.org
issues_comment: issues@hugegraph.apache.org
- discussions_status: dev@hugegraph.apache.org
+ discussions: dev@hugegraph.apache.org
discussions_comment: issues@hugegraph.apache.org
Review Comment:
@Z-HUANT we need also remove `discussions_comment` for same problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org