You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by "heyihong (via GitHub)" <gi...@apache.org> on 2023/09/25 23:19:51 UTC

[GitHub] [spark] heyihong commented on pull request #42859: [SPARK-43299][SS][CONNECT] Convert StreamingQueryException in Scala Client

heyihong commented on PR #42859:
URL: https://github.com/apache/spark/pull/42859#issuecomment-1734592867

   > We should also uncomment and verify these comments:
   > 
   > https://github.com/apache/spark/blob/1fdd46f173f7bc90e0523eb0a2d5e8e27e990102/connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryManager.scala#L124-L125
   > 
   > https://github.com/apache/spark/blob/1fdd46f173f7bc90e0523eb0a2d5e8e27e990102/connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/streaming/StreamingQuery.scala#L119-L120
   > 
   > But I could followup
   
   The test in [ClientStreamingQuerySuite](https://github.com/apache/spark/pull/42859/files#diff-a7c1e46208cfb9374d58ad677630f1724f621a33e1328b952cdbd3a301d37366) should validate that awaitTermination() throws StreamingQueryException. Since you have more contexts on streaming, could you help followup on this and verify these comments?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org