You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/10/28 12:09:34 UTC
[GitHub] [yunikorn-k8shim] pbacsko opened a new pull request, #470: [YUNIKORN-1375] [shim] pass group info from the shim to the core
pbacsko opened a new pull request, #470:
URL: https://github.com/apache/yunikorn-k8shim/pull/470
### What is this PR for?
The list of groups in `si.AddApplicationRequest` is not passed from the shim to core.
We need to make sure that we store the group inside the `Application` object and pass them when needed.
### What type of PR is it?
* [x] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1375
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] craigcondit closed pull request #470: [YUNIKORN-1375] [shim] pass group info from the shim to the core
Posted by GitBox <gi...@apache.org>.
craigcondit closed pull request #470: [YUNIKORN-1375] [shim] pass group info from the shim to the core
URL: https://github.com/apache/yunikorn-k8shim/pull/470
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #470: [YUNIKORN-1375] [shim] pass group info from the shim to the core
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #470:
URL: https://github.com/apache/yunikorn-k8shim/pull/470#issuecomment-1294932606
# [Codecov](https://codecov.io/gh/apache/yunikorn-k8shim/pull/470?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#470](https://codecov.io/gh/apache/yunikorn-k8shim/pull/470?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (af8e19b) into [master](https://codecov.io/gh/apache/yunikorn-k8shim/commit/26fe2dfffb6954073169587e67743296961edf72?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (26fe2df) will **increase** coverage by `0.02%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #470 +/- ##
==========================================
+ Coverage 68.01% 68.03% +0.02%
==========================================
Files 42 42
Lines 6916 6921 +5
==========================================
+ Hits 4704 4709 +5
Misses 2042 2042
Partials 170 170
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-k8shim/pull/470?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/cache/amprotocol\_mock.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/470/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL2FtcHJvdG9jb2xfbW9jay5nbw==) | `54.54% <100.00%> (+0.52%)` | :arrow_up: |
| [pkg/cache/application.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/470/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uLmdv) | `71.96% <100.00%> (+0.17%)` | :arrow_up: |
| [pkg/cache/context.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/470/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL2NvbnRleHQuZ28=) | `45.04% <100.00%> (+0.07%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org