[GitHub] [druid] imply-cheddar commented on a change in pull request #11717: Fix load-drop-load sequence for same segment and historical in http loadqueue peon

[GitBox <gi...@apache.org>]

imply-cheddar commented on a change in pull request #11717:
URL: https://github.com/apache/druid/pull/11717#discussion_r793142421



##########
File path: server/src/main/java/org/apache/druid/server/coordination/SegmentLoadDropHandler.java
##########
@@ -560,6 +560,11 @@ public void removeSegment(DataSegment segment, DataSegmentChangeCallback callbac
             },
             this::resolveWaitingFutures
         );
+      } else if (status.get().getState() == Status.STATE.SUCCESS) {

Review comment:
       Segment loads are idempotent, the node can be asked to load the same segment many times, it will only load it once.  If it gets asked multiple times, it will generate some log spew, but won't create a correctness bug.  The cache here is just an optimization on top of that idempotency to keep things out of synchronized blocks when not needed.  The intent of the change is to "invalidate" the cache as soon as the node believes that it has accurately reported back a meaningful success response.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org