You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "shanedell (via GitHub)" <gi...@apache.org> on 2023/08/04 17:09:46 UTC
[GitHub] [daffodil-vscode] shanedell opened a new pull request, #734: Update packaging to bundle the fonts and icons (.woff2 files)
shanedell opened a new pull request, #734:
URL: https://github.com/apache/daffodil-vscode/pull/734
Closes #729
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stricklandrbls commented on pull request #734: Update packaging to bundle the fonts and icons (.woff2 files)
Posted by "stricklandrbls (via GitHub)" <gi...@apache.org>.
stricklandrbls commented on PR #734:
URL: https://github.com/apache/daffodil-vscode/pull/734#issuecomment-1667908026
> @stricklandrbls Can you provide a link to where you got the fonts and icons? This will allow me to add them to the appropriate LICENSE/NOTICE files as mentioned by @stevedlawrence
I pull both of the fonts off of fonts.google.com and the icons were a bit more difficult to obtain for offline use but ultimately comes from https://fonts.google.com/icons.
The icons seemed to only be able to be used by adding the `href` to pull from the repository. I wanted to pull the source files since we expect some customers to use the DFDL extension in an air-gapped environment.
I couldn't find a straight forward way to do this so I had to trace the network fetch links to the server that held the source file and then download it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] shanedell commented on a diff in pull request #734: Update packaging to bundle the fonts and icons (.woff2 files)
Posted by "shanedell (via GitHub)" <gi...@apache.org>.
shanedell commented on code in PR #734:
URL: https://github.com/apache/daffodil-vscode/pull/734#discussion_r1286103211
##########
NOTICE:
##########
@@ -7,3 +7,10 @@ The Apache Software Foundation (http://www.apache.org/).
Based on source code originally developed by
- Concurrent Technologies Corporation (https://www.ctc.com/)
- Nteligen LLC (https://www.nteligen.com/)
+
+The following NOTICE information applies to binary components distributed with this project:
+
+- src/svelte/src/resources/icons/material-icons.woff2
+ This product bundles 'material-icons' from the above files.
+ This package is available under the Apache License v2 without a NOTICE:
+ Repository at: https://github.com/google/material-design-icons
Review Comment:
Oh yeah, I added it to both the `build/package/NONOTICE` and `NOTICE` file by mistake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] shanedell commented on pull request #734: Update packaging to bundle the fonts and icons (.woff2 files)
Posted by "shanedell (via GitHub)" <gi...@apache.org>.
shanedell commented on PR #734:
URL: https://github.com/apache/daffodil-vscode/pull/734#issuecomment-1667932854
@stricklandrbls Would you say the below are the repos for the fonts and icons used?
https://github.com/RedHatOfficial/RedHatFont
https://github.com/floriankarsten/space-grotesk
https://github.com/google/material-design-icons
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stricklandrbls commented on pull request #734: Update packaging to bundle the fonts and icons (.woff2 files)
Posted by "stricklandrbls (via GitHub)" <gi...@apache.org>.
stricklandrbls commented on PR #734:
URL: https://github.com/apache/daffodil-vscode/pull/734#issuecomment-1667937938
@shanedell Yes, those are the correct repos.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] shanedell merged pull request #734: Update packaging to bundle the fonts and icons (.woff2 files)
Posted by "shanedell (via GitHub)" <gi...@apache.org>.
shanedell merged PR #734:
URL: https://github.com/apache/daffodil-vscode/pull/734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] shanedell commented on pull request #734: Update packaging to bundle the fonts and icons (.woff2 files)
Posted by "shanedell (via GitHub)" <gi...@apache.org>.
shanedell commented on PR #734:
URL: https://github.com/apache/daffodil-vscode/pull/734#issuecomment-1668030345
@stevedlawrence I believe I added the icons and fonts to the appropriate files. I know there are still a couple missing dependencies as well but we have a ticket for those and I planned to do them in a different PR. I also noticed your issue with the incorrect license headers, we will get those resolved before 1.3.1-rc1 as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] shanedell commented on a diff in pull request #734: Update packaging to bundle the fonts and icons (.woff2 files)
Posted by "shanedell (via GitHub)" <gi...@apache.org>.
shanedell commented on code in PR #734:
URL: https://github.com/apache/daffodil-vscode/pull/734#discussion_r1286107844
##########
LICENSE:
##########
@@ -456,3 +455,198 @@ conditions of the following licenses.
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
+
+- src/svelte/src/resources/fonts/RedHatMono-Regular.woff2
+ This product bundles the above files from the 'RedHatFont' repo. (https://github.com/RedHatOfficial/RedHatFont)
+ These files are available under the SIL Open Font License, Version 1.1:
Review Comment:
Gotcha missed that on my last commit. The latest now has those added to the README.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] shanedell commented on pull request #734: Update packaging to bundle the fonts and icons (.woff2 files)
Posted by "shanedell (via GitHub)" <gi...@apache.org>.
shanedell commented on PR #734:
URL: https://github.com/apache/daffodil-vscode/pull/734#issuecomment-1667896368
@stricklandrbls Can you provide a link to where you got the fonts and icons? This will allow me to add them to the appropriate LICENSE/NOTICE files as mentioned by @stevedlawrence
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stevedlawrence commented on a diff in pull request #734: Update packaging to bundle the fonts and icons (.woff2 files)
Posted by "stevedlawrence (via GitHub)" <gi...@apache.org>.
stevedlawrence commented on code in PR #734:
URL: https://github.com/apache/daffodil-vscode/pull/734#discussion_r1286021678
##########
NOTICE:
##########
@@ -7,3 +7,10 @@ The Apache Software Foundation (http://www.apache.org/).
Based on source code originally developed by
- Concurrent Technologies Corporation (https://www.ctc.com/)
- Nteligen LLC (https://www.nteligen.com/)
+
+The following NOTICE information applies to binary components distributed with this project:
+
+- src/svelte/src/resources/icons/material-icons.woff2
+ This product bundles 'material-icons' from the above files.
+ This package is available under the Apache License v2 without a NOTICE:
+ Repository at: https://github.com/google/material-design-icons
Review Comment:
If a ALv2 licensed file does not include a NOTICE file then ti should not be mentioned in the NOTICE file. I think this project has been using a NONOTICE file to keep track of those so there is some documentation of it.
##########
LICENSE:
##########
@@ -360,7 +360,6 @@ conditions of the following licenses.
- src/adapter/activateDaffodilDebug.ts
- src/adapter/daffodilDebug.ts
- src/adapter/daffodilRuntime.ts
-- src/adapter/debugAdapter.ts
- src/adapter/extension.ts
Review Comment:
This above changes should really be part of a separate pull request fixing licensing issues.
##########
LICENSE:
##########
@@ -456,3 +455,198 @@ conditions of the following licenses.
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
+
+- src/svelte/src/resources/fonts/RedHatMono-Regular.woff2
+ This product bundles the above files from the 'RedHatFont' repo. (https://github.com/RedHatOfficial/RedHatFont)
+ These files are available under the SIL Open Font License, Version 1.1:
Review Comment:
ASF considers the SIL Open Font License as weak copyleft, ASF says this about that:
> You may include software under the following licenses in binary form within an Apache product if you label the inclusion appropriately (see above)
<sub>[[source](https://www.apache.org/legal/resolved.html#weak-copyleft-licenses)]</sub>
We have interpreted "label the inclusion appropriately" as meaning to as adding a line to the license section in our README. We should do that for boh this font and the other SIL font.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org