[GitHub] srkukarni commented on a change in pull request #3698: Adjust the serving threads to have a minimum of threads

[GitBox <gi...@apache.org>]

srkukarni commented on a change in pull request #3698: Adjust the serving threads to have a minimum of  threads
URL: https://github.com/apache/pulsar/pull/3698#discussion_r260842663
 
 

 ##########
 File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
 ##########
 @@ -146,7 +146,7 @@
             doc = "Number of threads to use for HTTP requests processing"
                 + " Default is set to `2 * Runtime.getRuntime().availableProcessors()`"
         )
-    private int numHttpServerThreads = 2 * Runtime.getRuntime().availableProcessors();
+    private int numHttpServerThreads = Math.max(4, 2 * Runtime.getRuntime().availableProcessors());
 
 Review comment:
   What do you think would be the right number?
   One thing is that with the current settings, on a one core machine, pulsar standalone wouldnt even come up. This fix solves that. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services