[GitHub] [arrow] kou commented on a diff in pull request #12749: ARROW-16069: [C++][FlightRPC] Refactor out gRPC error code handling

[GitBox <gi...@apache.org>]

kou commented on code in PR #12749:
URL: https://github.com/apache/arrow/pull/12749#discussion_r851671770


##########
python/pyarrow/tests/test_flight.py:
##########
@@ -355,17 +355,20 @@ def slow_stream():
 class ErrorFlightServer(FlightServerBase):
     """A Flight server that uses all the Flight-specific errors."""
 
+    errors = {
+        "internal": flight.FlightInternalError,

Review Comment:
   @lidavidm `flight` is `None` when we don't enable Flight.
   
   See also: https://github.com/ursacomputing/crossbow/runs/6046421802?check_suite_focus=true#step:6:2372
   
   ```text
   ==================================== ERRORS ====================================
   _ ERROR collecting usr/local/lib/python3.8/dist-packages/pyarrow/tests/test_flight.py _
   usr/local/lib/python3.8/dist-packages/pyarrow/tests/test_flight.py:355: in <module>
       class ErrorFlightServer(FlightServerBase):
   usr/local/lib/python3.8/dist-packages/pyarrow/tests/test_flight.py:359: in ErrorFlightServer
       "internal": flight.FlightInternalError,
   E   AttributeError: 'NoneType' object has no attribute 'FlightInternalError'
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org