You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/07/13 22:30:57 UTC

[GitHub] [trafficcontrol] srijeet0406 commented on a change in pull request #4802: Replace `json_build_object` from multi-interface implementations

srijeet0406 commented on a change in pull request #4802:
URL: https://github.com/apache/trafficcontrol/pull/4802#discussion_r453979446



##########
File path: traffic_ops/traffic_ops_golang/dbhelpers/db_helpers_test.go
##########
@@ -138,7 +146,133 @@ func TestGetCacheGroupByName(t *testing.T) {
 			}
 		})
 	}
+}
+
+// CreateServerInterfaces takes in a cache id and creates the interfaces/ipaddresses for it

Review comment:
       Nit: should not be a public function in the comment




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org