You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by "xiaoxiang781216 (via GitHub)" <gi...@apache.org> on 2023/02/21 02:32:56 UTC

[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1581: system/libuv: check GCC version before set special flags

xiaoxiang781216 commented on code in PR #1581:
URL: https://github.com/apache/nuttx-apps/pull/1581#discussion_r1112474965


##########
system/libuv/Makefile:
##########
@@ -49,10 +49,14 @@ CFLAGS += -I$(LIBUV_UNPACK)/src
 CFLAGS += -I$(LIBUV_UNPACK)/src/unix
 CFLAGS += -I$(LIBUV_UNPACK)/test
 CFLAGS += -Wno-shadow
-CFLAGS += -Wno-dangling-pointer
 CFLAGS += -DDEF_THREADPOOL_SIZE=CONFIG_LIBUV_THREADPOOL_SIZE
 CFLAGS += -DDEF_THREADPOOL_STACKSIZE=CONFIG_LIBUV_THREAD_STACKSIZE
 
+GCCVER = $(shell $(CC) --version | grep gcc | sed -r 's/.* ([0-9]+\.[0-9]+\.[0-9]+).*/\1/')
+ifeq ($(GCCVER),12.2.1)
+  CFLAGS += -Wno-dangling-pointer

Review Comment:
   let's fix the source code instead?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org