You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/07/07 04:24:32 UTC
[GitHub] [skywalking] xzyJavaX opened a new issue, #9322: [Bug]
xzyJavaX opened a new issue, #9322:
URL: https://github.com/apache/skywalking/issues/9322
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues.
### Apache SkyWalking Component
Java Agent (apache/skywalking-java)
### What happened
Use annotation org.apache.skywalking.apm.toolkit.trace.Tag, for example：
```
@Service
public class DemoService {
@Tag(key = "kkk", value = "vvv")
public void tag() {
//
}
}
```
```
@GetMapping("tag")
public String tag() {
demoService.tag();
return "tag";
}
```
Access interface “/tag”, key "kkk" will exist，value will be null.
So is this a feature or a bug？
Related documents：https://skywalking.apache.org/docs/skywalking-java/v8.11.0/en/setup/service-agent/java-agent/application-toolkit-trace/
### What you expected to happen
skip
### How to reproduce
Start skywalking APM locall, use the above code to mount skywalking-agent and start it
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lujiajing1126 commented on issue #9322: About annotation org.apache.skywalking.apm.toolkit.trace.Tag
Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on issue #9322:
URL: https://github.com/apache/skywalking/issues/9322#issuecomment-1177073664
I've checked the OAP backend, it just received "null".
The problem is whether plain text is supported by the `@Tag` annotation. According to the current implementation, only expression is supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #9322: About annotation org.apache.skywalking.apm.toolkit.trace.Tag
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9322:
URL: https://github.com/apache/skywalking/issues/9322#issuecomment-1177055452
You need to check data first, whether key value is collected by the agent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #9322: About annotation org.apache.skywalking.apm.toolkit.trace.Tag
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9322:
URL: https://github.com/apache/skywalking/issues/9322#issuecomment-1177058616
And use 9.1 backend and UI if data gets reported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #9322: About annotation org.apache.skywalking.apm.toolkit.trace.Tag
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #9322: About annotation org.apache.skywalking.apm.toolkit.trace.Tag
URL: https://github.com/apache/skywalking/issues/9322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #9322: About annotation org.apache.skywalking.apm.toolkit.trace.Tag
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9322:
URL: https://github.com/apache/skywalking/issues/9322#issuecomment-1177081301
I can't find doc mentioned plain text supported. AKA, it should be not assumed supported.
Then there is no bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #9322: About annotation org.apache.skywalking.apm.toolkit.trace.Tag
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9322:
URL: https://github.com/apache/skywalking/issues/9322#issuecomment-1177072348
AFAIK, the tag collecting is tested in every PR through
https://github.com/apache/skywalking-java/blob/19dd412b34784d33188819fd11a3b508177df9d0/test/plugin/scenarios/apm-toolkit-trace-scenario/config/expectedData.yaml#L61
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org