You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by bb...@apache.org on 2021/03/04 22:24:26 UTC

[geode-native] branch develop updated: GEODE-8994: Fix log line in EventId ctor (#756)

This is an automated email from the ASF dual-hosted git repository.

bbender pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/geode-native.git


The following commit(s) were added to refs/heads/develop by this push:
     new 6f82926  GEODE-8994: Fix log line in EventId ctor (#756)
6f82926 is described below

commit 6f82926ea4f9fb1ede66b8c67e911a1c1c66aeb3
Author: Blake Bender <bb...@pivotal.io>
AuthorDate: Thu Mar 4 14:24:18 2021 -0800

    GEODE-8994: Fix log line in EventId ctor (#756)
    
    - memId isn't a string, need to convert it first or we'll log garbage.
---
 cppcache/src/EventId.cpp | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/cppcache/src/EventId.cpp b/cppcache/src/EventId.cpp
index 62c0539..d53090a 100644
--- a/cppcache/src/EventId.cpp
+++ b/cppcache/src/EventId.cpp
@@ -23,6 +23,7 @@
 #include <geode/DataInput.hpp>
 
 #include "ClientProxyMembershipID.hpp"
+#include "Utils.hpp"
 #include "util/Log.hpp"
 
 namespace apache {
@@ -137,7 +138,8 @@ std::shared_ptr<Serializable> EventId::createDeserializable() {
 EventId::EventId(char* memId, uint32_t memIdLen, int64_t thr, int64_t seq) {
   LOGDEBUG("EventId::EventId(%p) - memId=%s, memIdLen=%d, thr=%" PRId64
            ", seq=%" PRId64,
-           this, memId, memIdLen, thr, seq);
+           this, Utils::convertBytesToString(memId, memIdLen).c_str(), memIdLen,
+           thr, seq);
   // TODO: statics being assigned; not thread-safe??
   std::memcpy(clientId_, memId, memIdLen);
   clientIdLength_ = memIdLen;