You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Stefan Fritsch <sf...@sfritsch.de> on 2011/12/28 15:57:42 UTC
Looking for Windows testers for r1225199
Hi,
> Author: sf
> Date: Wed Dec 28 14:54:49 2011
> New Revision: 1225199
>
> URL: http://svn.apache.org/viewvc?rev=1225199&view=rev
> Log:
> Check during configtest that the directories for error logs exist
>
> Testing under Windows is welcome
>
> PR: 29941
I think that the combination of ap_server_root_relative and
ap_make_dirstr_parent should also work under Windows with backslashes
as path separators. But it would be nice if somebody could test that
before I backport to 2.4.
Cheers,
Stefan
Re: Looking for Windows testers for r1225199
Posted by Stefan Fritsch <sf...@sfritsch.de>.
On Wednesday 28 December 2011, Mario Brandt wrote:
> I guess it is now r1225223 ?
Yes, r1225199 plus r1225223.
Re: Looking for Windows testers for r1225199
Posted by Mario Brandt <jb...@gmail.com>.
I guess it is now r1225223 ?
Cheers
Mario
On Wed, Dec 28, 2011 at 15:57, Stefan Fritsch <sf...@sfritsch.de> wrote:
> Hi,
>
>> Author: sf
>> Date: Wed Dec 28 14:54:49 2011
>> New Revision: 1225199
>>
>> URL: http://svn.apache.org/viewvc?rev=1225199&view=rev
>> Log:
>> Check during configtest that the directories for error logs exist
>>
>> Testing under Windows is welcome
>>
>> PR: 29941
>
> I think that the combination of ap_server_root_relative and
> ap_make_dirstr_parent should also work under Windows with backslashes
> as path separators. But it would be nice if somebody could test that
> before I backport to 2.4.
>
> Cheers,
> Stefan
Re: Looking for Windows testers for r1225199
Posted by Stefan Fritsch <sf...@sfritsch.de>.
Hi Gregg,
On Sunday 15 January 2012, Gregg L. Smith wrote:
> > Build at r1226558, post both these revisions.
> > Missing main log directory shows up on console if started from
> > there, or Eventlog (syslog) if started as service
> > c:\Apache24\bin>httpd
> > (OS 2)The system cannot find the file specified. : AH02291:
> > Cannot access directory 'c:/Apache24/lo
> > gs/' for main error log
> > AH00014: Configuration check failed
> >
> > vhost specific, shows in error log
> >
> > CustomLog "\\some\\bogus\\path\\access.log" common
> >
> > [Fri Jan 13 11:20:30.038382 2012] [log_config:error] [pid 420:tid
> > 636] (OS 3)The system cannot find the path specified. :
> > AH00649: could not open transfer log file
> > c:/some/bogus/path/access.log.
> > AH00015: Unable to open logs
> >
> > Looks fine!
>
> In the spirit of PR 229941 and for the vhost specific part, no it's
> not fine. It does not show to console and Apache does not just
> ignore that vhost and move on, it stops, so you need to dig into
> the logs. Being an enhancement PR no foul.
that's OK I think. The change only implements the check for the error
logs. I will add the same check for the access logs now that it is
confirmed that the check works with backslashes and drive letters.
Thanks for the testing.
Cheers,
Stefan
Re: Looking for Windows testers for r1225199
Posted by "Gregg L. Smith" <gl...@gknw.net>.
On 1/13/2012 11:30 AM, Gregg L. Smith wrote:
> On 12/28/2011 6:57 AM, Stefan Fritsch wrote:
>> Hi,
>>
>>> Author: sf
>>> Date: Wed Dec 28 14:54:49 2011
>>> New Revision: 1225199
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1225199&view=rev
>>> Log:
>>> Check during configtest that the directories for error logs exist
>>>
>>> Testing under Windows is welcome
>>>
>>> PR: 29941
>> I think that the combination of ap_server_root_relative and
>> ap_make_dirstr_parent should also work under Windows with backslashes
>> as path separators. But it would be nice if somebody could test that
>> before I backport to 2.4.
>>
>> Cheers,
>> Stefan
>>
> Stefan,
>
> Build at r1226558, post both these revisions.
> Missing main log directory shows up on console if started from there,
> or Eventlog (syslog) if started as service
> c:\Apache24\bin>httpd
> (OS 2)The system cannot find the file specified. : AH02291: Cannot
> access directory 'c:/Apache24/lo
> gs/' for main error log
> AH00014: Configuration check failed
>
> vhost specific, shows in error log
>
> CustomLog "\\some\\bogus\\path\\access.log" common
> [Fri Jan 13 11:20:30.038382 2012] [log_config:error] [pid 420:tid 636]
> (OS 3)The system cannot find the path specified. : AH00649: could not
> open transfer log file c:/some/bogus/path/access.log.
> AH00015: Unable to open logs
>
> Looks fine!
In the spirit of PR 229941 and for the vhost specific part, no it's not
fine. It does not show to console and Apache does not just ignore that
vhost and move on, it stops, so you need to dig into the logs. Being an
enhancement PR no foul.
Re: Looking for Windows testers for r1225199
Posted by "Gregg L. Smith" <gl...@gknw.net>.
On 12/28/2011 6:57 AM, Stefan Fritsch wrote:
> Hi,
>
>> Author: sf
>> Date: Wed Dec 28 14:54:49 2011
>> New Revision: 1225199
>>
>> URL: http://svn.apache.org/viewvc?rev=1225199&view=rev
>> Log:
>> Check during configtest that the directories for error logs exist
>>
>> Testing under Windows is welcome
>>
>> PR: 29941
> I think that the combination of ap_server_root_relative and
> ap_make_dirstr_parent should also work under Windows with backslashes
> as path separators. But it would be nice if somebody could test that
> before I backport to 2.4.
>
> Cheers,
> Stefan
>
Stefan,
Build at r1226558, post both these revisions.
Missing main log directory shows up on console if started from there, or
Eventlog (syslog) if started as service
c:\Apache24\bin>httpd
(OS 2)The system cannot find the file specified. : AH02291: Cannot
access directory 'c:/Apache24/lo
gs/' for main error log
AH00014: Configuration check failed
vhost specific, shows in error log
CustomLog "\\some\\bogus\\path\\access.log" common
[Fri Jan 13 11:20:30.038382 2012] [log_config:error] [pid 420:tid 636]
(OS 3)The system cannot find the path specified. : AH00649: could not
open transfer log file c:/some/bogus/path/access.log.
AH00015: Unable to open logs
Looks fine!
Cheers,
Gregg