You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Adrian Cole <no...@github.com> on 2014/10/04 19:32:18 UTC
[jclouds] Lock S3ClientMockTest using OkHttp (#545)
Alternate approach to #502. At the level of S3, we are testing that the headers are actually applied, not trying to test the behavior of a specific JRE's HttpUrlConnection. Using OkHttp, we can decouple this test from flaking out in various environments.
You can merge this Pull Request by running:
git pull https://github.com/adriancole/jclouds adrian.decouple-s3-mock-from-jre
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/545
-- Commit Summary --
* Rather than rely on or work around JRE behavior based, lock S3ClientMockTest using OkHttp.
-- File Changes --
M apis/s3/pom.xml (6)
M apis/s3/src/test/java/org/jclouds/s3/S3ClientMockTest.java (9)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/545.patch
https://github.com/jclouds/jclouds/pull/545.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/545
Re: [jclouds] Lock S3ClientMockTest using OkHttp (#545)
Posted by Adrian Cole <no...@github.com>.
bump on this @andrewgaul @demobox as it is always hanging w/o it (at least on my laptop)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/545#issuecomment-57969325
Re: [jclouds] Lock S3ClientMockTest using OkHttp (#545)
Posted by Adrian Cole <ad...@gmail.com>.
This is an unrelated checkstyle error (build passed fine). Will look into
it and see if reprodicable.
Re: [jclouds] Lock S3ClientMockTest using OkHttp (#545)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1221](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1221/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/545#issuecomment-57914247
Re: [jclouds] Lock S3ClientMockTest using OkHttp (#545)
Posted by Adrian Cole <no...@github.com>.
cherry-picked into master, 1.8.x
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/545#issuecomment-57971219
Re: [jclouds] Lock S3ClientMockTest using OkHttp (#545)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-6 #132](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/132/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/545#issuecomment-57912738
Re: [jclouds] Lock S3ClientMockTest using OkHttp (#545)
Posted by Adrian Cole <no...@github.com>.
Closed #545.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/545#event-174339845
Re: [jclouds] Lock S3ClientMockTest using OkHttp (#545)
Posted by Adrian Cole <no...@github.com>.
> @@ -44,13 +45,11 @@
> @Test(singleThreaded = true)
> public class S3ClientMockTest {
>
> - private static final Set<Module> modules = ImmutableSet.<Module> of(
> + private static final Set<Module> modules = ImmutableSet.<Module> of(new OkHttpCommandExecutorServiceModule(),
yep. because okhttp is not dependent on HttpUrlConnectionImpl, which is the class that changes with each jre!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/545/files#r18440490
Re: [jclouds] Lock S3ClientMockTest using OkHttp (#545)
Posted by Andrew Phillips <no...@github.com>.
Just a minor comment to, er, add a comment - otherwise, looks good to me: +1. Thanks, @adriancole!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/545#issuecomment-57969710
Re: [jclouds] Lock S3ClientMockTest using OkHttp (#545)
Posted by BuildHive <no...@github.com>.
[jclouds ยป jclouds #1705](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1705/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/545#issuecomment-57918227
Re: [jclouds] Lock S3ClientMockTest using OkHttp (#545)
Posted by Andrew Phillips <no...@github.com>.
> @@ -44,13 +45,11 @@
> @Test(singleThreaded = true)
> public class S3ClientMockTest {
>
> - private static final Set<Module> modules = ImmutableSet.<Module> of(
> + private static final Set<Module> modules = ImmutableSet.<Module> of(new OkHttpCommandExecutorServiceModule(),
Add a comment here to explain why we're using OkHttp?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/545/files#r18440451