You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by dhull <gi...@git.apache.org> on 2017/08/08 20:50:40 UTC
[GitHub] thrift pull request #1329: THRIFT-4279: Fix include path in generated Erlang...
GitHub user dhull opened a pull request:
https://github.com/apache/thrift/pull/1329
THRIFT-4279: Fix include path in generated Erlang Thrift sources.
The change in THRIFT-4270 inadvertantly modified the include directives in the generated Erlang sources to include the gen-erl directory in the path to the include file. This commit restores the
previous behavior.
Example include directive before the THRIFT-4270 change:
```erlang
-include("constants_demo_types.hrl").
```
Example include directive after the THRIFT-4270 change:
```erlang
-include("test/gen-erl/constants_demo_types.hrl").
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dhull/thrift thrift-4279-erlang-fix-include-path
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1329.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1329
----
commit 4aa8fca3955ff6eb1f6cc810a8cad50a74294caa
Author: David Hull <da...@openx.com>
Date: 2017-08-08T17:42:37Z
THRIFT-4279: Fix include path in generated Erlang Thrift sources.
The change in THRIFT-4270 inadvertantly modified the include
directives in the generated Erlang sources to include the gen-erl
directory in the path to the include file. This commit restores the
previous behavior.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1329: THRIFT-4279: Fix include path in generated Erlang...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1329
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1329: THRIFT-4279: Fix include path in generated Erlang Thrift...
Posted by dhull <gi...@git.apache.org>.
Github user dhull commented on the issue:
https://github.com/apache/thrift/pull/1329
It appears to me that the AppVeyor build failure is due it a problem with the build machine:
```
CMake Error at C:/Program Files (x86)/CMake/share/cmake-3.8/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
Could NOT find FLEX (missing: FLEX_EXECUTABLE)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1329: THRIFT-4279: Fix include path in generated Erlang Thrift...
Posted by djnym <gi...@git.apache.org>.
Github user djnym commented on the issue:
https://github.com/apache/thrift/pull/1329
@Jens-G this probably needs to be merged assuming it passes the checks as we don't want to generate bad code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---