You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by twalthr <gi...@git.apache.org> on 2016/03/03 16:06:21 UTC

[GitHub] flink pull request: [FLINK-3566] [FLINK-3563] Input type validatio...

GitHub user twalthr opened a pull request:

    https://github.com/apache/flink/pull/1759

    [FLINK-3566] [FLINK-3563] Input type validation improvements

    This PR fixes issues with the input type validation. 
    
    [FLINK-3566] Custom type information have been interpreted as basic or tuple types, because their `isTupleType()`/`isBasicType()` methods returned `true`. Subclasses of GenericTypes caused problems.
    
    [FLINK-3563] Subclasses of GenericTypes caused problems.
    
    @gyfora Can you check if you still have problems?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/twalthr/flink FLINK-3563

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1759.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1759
    
----
commit fe8ae3789f9260b48ac8a7551dd42b258c117b5f
Author: twalthr <tw...@apache.org>
Date:   2016-03-03T14:44:28Z

    [FLINK-3566] [FLINK-3563] Input type validation improvements

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3566] [FLINK-3563] Input type validatio...

Posted by chobeat <gi...@git.apache.org>.
Github user chobeat commented on the pull request:

    https://github.com/apache/flink/pull/1759#issuecomment-191857083
  
    I tested it too and it works perfectly both on an example case and in the code where the problem arose.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3566] [FLINK-3563] Input type validatio...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/1759


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3566] [FLINK-3563] Input type validatio...

Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1759#issuecomment-192200612
  
    +1
    
    to merge this into the 1.0 and 1.1 branches


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3566] [FLINK-3563] Input type validatio...

Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1759#issuecomment-192362699
  
    Will merge this...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3566] [FLINK-3563] Input type validatio...

Posted by gyfora <gi...@git.apache.org>.
Github user gyfora commented on the pull request:

    https://github.com/apache/flink/pull/1759#issuecomment-191821834
  
    I tested it in my application where I was previously having both issues.
    
    Now it works perfectly, thanks!
    
    +1 from me :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---