You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by mi...@apache.org on 2018/09/08 22:31:32 UTC
[maven-scm] branch SCM-910 created (now 148287b)
This is an automated email from the ASF dual-hosted git repository.
michaelo pushed a change to branch SCM-910
in repository https://gitbox.apache.org/repos/asf/maven-scm.git.
at 148287b [SCM-910] SvnScmProviderRepository#parseUrl(): skip parsing of user info for file:// URLs
This branch includes the following new commits:
new 148287b [SCM-910] SvnScmProviderRepository#parseUrl(): skip parsing of user info for file:// URLs
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[maven-scm] 01/01: [SCM-910] SvnScmProviderRepository#parseUrl():
skip parsing of user info for file:// URLs
Posted by mi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
michaelo pushed a commit to branch SCM-910
in repository https://gitbox.apache.org/repos/asf/maven-scm.git
commit 148287be35a4978319cee916c8fd9123399cfc17
Author: Michael Osipov <mi...@apache.org>
AuthorDate: Sun Sep 9 00:20:55 2018 +0200
[SCM-910] SvnScmProviderRepository#parseUrl(): skip parsing of user info for file:// URLs
---
.../maven/scm/provider/svn/repository/SvnScmProviderRepository.java | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svn-commons/src/main/java/org/apache/maven/scm/provider/svn/repository/SvnScmProviderRepository.java b/maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svn-commons/src/main/java/org/apache/maven/scm/provider/svn/repository/SvnScmProviderRepository.java
index f4f76c0..5b12df0 100644
--- a/maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svn-commons/src/main/java/org/apache/maven/scm/provider/svn/repository/SvnScmProviderRepository.java
+++ b/maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svn-commons/src/main/java/org/apache/maven/scm/provider/svn/repository/SvnScmProviderRepository.java
@@ -161,7 +161,9 @@ public class SvnScmProviderRepository
int indexAt = urlPath.indexOf( '@' );
- if ( indexAt > 0 && !getProtocol().startsWith( "svn+" ) )
+ // a file:// URL may contain userinfo according to RFC 8089, but our implementation is broken
+ // extract user information, broken see SCM-909
+ if ( indexAt > 0 && !getProtocol().startsWith( "svn+" ) && !getProtocol().equals( "file://" ) )
{
String userPassword = urlPath.substring( 0, indexAt );
if ( userPassword.indexOf( ':' ) < 0 )