You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "yunfengzhou-hub (via GitHub)" <gi...@apache.org> on 2024/11/25 03:15:33 UTC
[PR] [flink] Avoid deprecated usages about Configuration [paimon]
yunfengzhou-hub opened a new pull request, #4584:
URL: https://github.com/apache/paimon/pull/4584
<!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: #4442
<!-- What is the purpose of the change -->
This pull request replaces deprecated usages about Flink Configuration with latest recommended ways.
### Tests
<!-- List UT and IT cases to verify this change -->
Existing test cases are used to verify this change.
### API and Format
<!-- Does this change affect API or storage format -->
This change does not affect API or storage format.
### Documentation
<!-- Does this change introduce a new feature -->
This change does not affect introduce a new feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] Avoid deprecated usages about Configuration [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #4584:
URL: https://github.com/apache/paimon/pull/4584#discussion_r1857689859
##########
paimon-flink/paimon-flink-1.15/src/test/java/org/apache/paimon/flink/sink/cdc/KryoSerializerUtils.java:
##########
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.paimon.flink.sink.cdc;
+
+import org.apache.flink.api.common.ExecutionConfig;
+import org.apache.flink.api.java.typeutils.runtime.kryo.KryoSerializer;
+
+/** Utility class for Kryo serializer to resolve compatibility issue. */
+public class KryoSerializerUtils {
Review Comment:
Just test code? Do we need to care about old FLINK VERIONS? Or just workaround it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] Avoid deprecated usages about Configuration [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #4584:
URL: https://github.com/apache/paimon/pull/4584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] Avoid deprecated usages about Configuration [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #4584:
URL: https://github.com/apache/paimon/pull/4584#discussion_r1857691500
##########
paimon-flink/paimon-flink-common/src/test/java/org/apache/paimon/flink/RescaleBucketITCase.java:
##########
@@ -106,9 +106,7 @@ public void testSuspendAndRecoverAfterRescaleOverwrite() throws Exception {
assertThat(batchSql("SELECT * FROM T3")).containsExactlyInAnyOrderElementsOf(committedData);
// step5: resume streaming job
- sEnv.getConfig()
- .getConfiguration()
- .set(SavepointConfigOptions.SAVEPOINT_PATH, savepointPath);
+ sEnv.getConfig().getConfiguration().set(StateRecoveryOptions.SAVEPOINT_PATH, savepointPath);
Review Comment:
test code, just workaround it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] Avoid deprecated usages about Configuration [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #4584:
URL: https://github.com/apache/paimon/pull/4584#discussion_r1857691166
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/source/FlinkSourceBuilder.java:
##########
@@ -331,30 +331,30 @@ private void assertStreamingConfigurationForAlignMode(StreamExecutionEnvironment
checkArgument(
checkpointConfig.isCheckpointingEnabled(),
"The align mode of paimon source is only supported when checkpoint enabled. Please set "
- + ExecutionCheckpointingOptions.CHECKPOINTING_INTERVAL.key()
+ + CheckpointingOptions.CHECKPOINTING_INTERVAL.key()
Review Comment:
I think it is OK to just use string...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org