[GitHub] [incubator-iceberg] ryanrupp commented on a change in pull request #183: Fix reading of Iceberg Parquet write properties for row group, page a…

[GitBox <gi...@apache.org>]

ryanrupp commented on a change in pull request #183: Fix reading of Iceberg Parquet write properties for row group, page a…
URL: https://github.com/apache/incubator-iceberg/pull/183#discussion_r282560971
 
 

 ##########
 File path: parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java
 ##########
 @@ -183,10 +177,13 @@ void forwardConfig(String parquetProperty, String icebergProperty, String defaul
           conf.set(entry.getKey(), entry.getValue());
         }
 
-        long rowGroupSize = Long.parseLong(config.getOrDefault(
-            PARQUET_ROW_GROUP_SIZE_BYTES, PARQUET_ROW_GROUP_SIZE_BYTES_DEFAULT));
+        ParquetProperties parquetProperties = ParquetProperties.builder()
 
 Review comment:
   I let this default as the `else` path defaults as well (so both use V1 by default). Thinking I'll make this more explicit and just have a constant in this class hardcoded to V1 then for now and both paths will use that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org