You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/08/31 20:20:40 UTC

[GitHub] [beam] wannabehero commented on a diff in pull request #22941: Allows to use databaseio with postgres driver

wannabehero commented on code in PR #22941:
URL: https://github.com/apache/beam/pull/22941#discussion_r959991565


##########
sdks/go/pkg/beam/io/databaseio/writer_test.go:
##########
@@ -0,0 +1,33 @@
+package databaseio
+
+import "testing"
+
+func TestValueTemplateGenerator(t *testing.T) {

Review Comment:
   Thanks for the review!
   
   I've updated the tests according to the reference you mentioned. I also refactored `colsCount` to `columnCount` to match other code.
   
   Also added a missing license (I think it was failing the check).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org