You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2015/12/04 18:33:49 UTC
Review Request 40975: Document that libprocess ignores SIGPIPE
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40975/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Repository: mesos
Description
-------
Document that libprocess ignores SIGPIPE.
Diffs
-----
3rdparty/libprocess/README.md c3f309a7dc1c94882c4cc97eeaf0736c2fca0ba5
Diff: https://reviews.apache.org/r/40975/diff/
Testing
-------
None.
Thanks,
James Peach
Re: Review Request 40975: Document that libprocess ignores SIGPIPE
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40975/#review109007
-----------------------------------------------------------
Patch looks great!
Reviews applied: [40975]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 4, 2015, 5:33 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40975/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2015, 5:33 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Document that libprocess ignores SIGPIPE.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/README.md c3f309a7dc1c94882c4cc97eeaf0736c2fca0ba5
>
> Diff: https://reviews.apache.org/r/40975/diff/
>
>
> Testing
> -------
>
> None.
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 40975: Document that libprocess ignores SIGPIPE
Posted by James Peach <jp...@apache.org>.
> On Jan. 4, 2016, 9:14 p.m., Mesos ReviewBot wrote:
> > Bad patch!
> >
> > Reviews applied: [40975]
> >
> > Failed command: ./support/apply-review.sh -n -r 40975
> >
> > Error:
> > 2016-01-04 21:14:40 URL:https://reviews.apache.org/r/40975/diff/raw/ [1164/1164] -> "40975.patch" [1]
> > No files to lint
> >
> > Error: Commit message summary (the first line) must end in a period.
Well AFAICT "Document that libprocess ignores SIGPIPE." *does* end in a period.
- James
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40975/#review112647
-----------------------------------------------------------
On Jan. 4, 2016, 4:31 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40975/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2016, 4:31 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Document that libprocess ignores SIGPIPE.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/README.md 6a47f6772bb7a74af368ed970af0f1c154a070e3
>
> Diff: https://reviews.apache.org/r/40975/diff/
>
>
> Testing
> -------
>
> None.
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 40975: Document that libprocess ignores SIGPIPE
Posted by James Peach <jp...@apache.org>.
> On Jan. 4, 2016, 9:14 p.m., Mesos ReviewBot wrote:
> > Bad patch!
> >
> > Reviews applied: [40975]
> >
> > Failed command: ./support/apply-review.sh -n -r 40975
> >
> > Error:
> > 2016-01-04 21:14:40 URL:https://reviews.apache.org/r/40975/diff/raw/ [1164/1164] -> "40975.patch" [1]
> > No files to lint
> >
> > Error: Commit message summary (the first line) must end in a period.
>
> James Peach wrote:
> Well AFAICT "Document that libprocess ignores SIGPIPE." *does* end in a period.
>
> Vinod Kone wrote:
> the summary line above doesn't have a period. am i missing something?
``apply-review.sh`` is adding tht somehow. The commit that I fed to ``post-reviews.sh`` doesn't have it.
```
mesos.git jpeach$ git show
commit efa6b867e7c421de3102bd00674ef2aa37610de8
Author: James Peach <jp...@apache.org>
Date: Fri Dec 4 09:31:44 2015 -0800
Document that libprocess ignores SIGPIPE.
Review: https://reviews.apache.org/r/40975
diff --git a/3rdparty/libprocess/README.md b/3rdparty/libprocess/README.md
index 6a47f67..3bd0c7c 100644
--- a/3rdparty/libprocess/README.md
+++ b/3rdparty/libprocess/README.md
@@ -30,6 +30,7 @@ At a higher level, functional composition of processes is facilitated using [fut
* [HTTP](#http)
* [Testing](#testing)
* [Miscellaneous Primitives](#miscellaneous-primitives)
+* [Signal Handling](#signal-handling)
---
@@ -653,3 +654,13 @@ int main()
### `async`
Async defines a function template for asynchronously executing function closures. It provides their results as [futures](#futures-and-promises).
+
+## Signal handling
+
+In general, libprocess does not depend on signals or interfere with
+the host processes signal handling policy. The exception is that
+it always ignores `SIGPIPE` globally, so the host process must not
+depend on `SIGPIPE` being delivered when performing I/O on disconnected
+pipes or sockets. libprocess APIs that perform I/O will always
+return an appropriately wrapped EPIPE error code (usually a stout
+`ErrnoError` object) instead of raising `SIGPIPE`.
```
- James
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40975/#review112647
-----------------------------------------------------------
On Jan. 4, 2016, 4:31 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40975/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2016, 4:31 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Document that libprocess ignores SIGPIPE.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/README.md 6a47f6772bb7a74af368ed970af0f1c154a070e3
>
> Diff: https://reviews.apache.org/r/40975/diff/
>
>
> Testing
> -------
>
> None.
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 40975: Document that libprocess ignores SIGPIPE
Posted by Vinod Kone <vi...@gmail.com>.
> On Jan. 4, 2016, 9:14 p.m., Mesos ReviewBot wrote:
> > Bad patch!
> >
> > Reviews applied: [40975]
> >
> > Failed command: ./support/apply-review.sh -n -r 40975
> >
> > Error:
> > 2016-01-04 21:14:40 URL:https://reviews.apache.org/r/40975/diff/raw/ [1164/1164] -> "40975.patch" [1]
> > No files to lint
> >
> > Error: Commit message summary (the first line) must end in a period.
>
> James Peach wrote:
> Well AFAICT "Document that libprocess ignores SIGPIPE." *does* end in a period.
the summary line above doesn't have a period. am i missing something?
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40975/#review112647
-----------------------------------------------------------
On Jan. 4, 2016, 4:31 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40975/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2016, 4:31 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Document that libprocess ignores SIGPIPE.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/README.md 6a47f6772bb7a74af368ed970af0f1c154a070e3
>
> Diff: https://reviews.apache.org/r/40975/diff/
>
>
> Testing
> -------
>
> None.
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 40975: Document that libprocess ignores SIGPIPE
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40975/#review112647
-----------------------------------------------------------
Bad patch!
Reviews applied: [40975]
Failed command: ./support/apply-review.sh -n -r 40975
Error:
2016-01-04 21:14:40 URL:https://reviews.apache.org/r/40975/diff/raw/ [1164/1164] -> "40975.patch" [1]
No files to lint
Error: Commit message summary (the first line) must end in a period.
- Mesos ReviewBot
On Jan. 4, 2016, 4:31 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40975/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2016, 4:31 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Document that libprocess ignores SIGPIPE.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/README.md 6a47f6772bb7a74af368ed970af0f1c154a070e3
>
> Diff: https://reviews.apache.org/r/40975/diff/
>
>
> Testing
> -------
>
> None.
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 40975: Document that libprocess ignores SIGPIPE
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40975/#review113386
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/README.md (line 665)
<https://reviews.apache.org/r/40975/#comment173993>
`EPIPE` in backticks makes sense, I think
- Till Toenshoff
On Jan. 7, 2016, 5:30 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40975/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2016, 5:30 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Document that libprocess ignores SIGPIPE.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/README.md 6a47f6772bb7a74af368ed970af0f1c154a070e3
>
> Diff: https://reviews.apache.org/r/40975/diff/
>
>
> Testing
> -------
>
> None.
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 40975: Document that libprocess ignores SIGPIPE.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40975/#review113589
-----------------------------------------------------------
Patch looks great!
Reviews applied: [40975]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 8, 2016, 9:19 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40975/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2016, 9:19 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Document that libprocess ignores SIGPIPE.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/README.md 6a47f6772bb7a74af368ed970af0f1c154a070e3
>
> Diff: https://reviews.apache.org/r/40975/diff/
>
>
> Testing
> -------
>
> None.
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 40975: Document that libprocess ignores SIGPIPE.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40975/
-----------------------------------------------------------
(Updated Jan. 8, 2016, 9:19 p.m.)
Review request for mesos and Ben Mahler.
Summary (updated)
-----------------
Document that libprocess ignores SIGPIPE.
Repository: mesos
Description
-------
Document that libprocess ignores SIGPIPE.
Diffs
-----
3rdparty/libprocess/README.md 6a47f6772bb7a74af368ed970af0f1c154a070e3
Diff: https://reviews.apache.org/r/40975/diff/
Testing
-------
None.
Thanks,
James Peach
Re: Review Request 40975: Document that libprocess ignores SIGPIPE
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40975/
-----------------------------------------------------------
(Updated Jan. 8, 2016, 8:58 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Added backticks around EPIPE.
Repository: mesos
Description
-------
Document that libprocess ignores SIGPIPE.
Diffs (updated)
-----
3rdparty/libprocess/README.md 6a47f6772bb7a74af368ed970af0f1c154a070e3
Diff: https://reviews.apache.org/r/40975/diff/
Testing
-------
None.
Thanks,
James Peach
Re: Review Request 40975: Document that libprocess ignores SIGPIPE
Posted by James Peach <jp...@apache.org>.
> On Jan. 7, 2016, 6:32 p.m., Mesos ReviewBot wrote:
> > Bad patch!
> >
> > Reviews applied: [40975]
> >
> > Failed command: ./support/apply-review.sh -n -r 40975
> >
> > Error:
> > 2016-01-07 18:32:55 URL:https://reviews.apache.org/r/40975/diff/raw/ [1164/1164] -> "40975.patch" [1]
> > No files to lint
> >
> > Error: Commit message summary (the first line) must end in a period.
I don't know how to fix this. The subject is correct in the commit I am pushing; I don't know how to convince the tooling of that.
- James
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40975/#review113286
-----------------------------------------------------------
On Jan. 7, 2016, 5:30 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40975/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2016, 5:30 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Document that libprocess ignores SIGPIPE.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/README.md 6a47f6772bb7a74af368ed970af0f1c154a070e3
>
> Diff: https://reviews.apache.org/r/40975/diff/
>
>
> Testing
> -------
>
> None.
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 40975: Document that libprocess ignores SIGPIPE
Posted by Joseph Wu <jo...@mesosphere.io>.
> On Jan. 7, 2016, 10:32 a.m., Mesos ReviewBot wrote:
> > Bad patch!
> >
> > Reviews applied: [40975]
> >
> > Failed command: ./support/apply-review.sh -n -r 40975
> >
> > Error:
> > 2016-01-07 18:32:55 URL:https://reviews.apache.org/r/40975/diff/raw/ [1164/1164] -> "40975.patch" [1]
> > No files to lint
> >
> > Error: Commit message summary (the first line) must end in a period.
>
> James Peach wrote:
> I don't know how to fix this. The subject is correct in the commit I am pushing; I don't know how to convince the tooling of that.
`support/post-reviews.sh` doesn't overwrite the review board "Summary" (so if you've added the period there, ReviewBot will still complain). You can just edit the field on the web UI.
- Joseph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40975/#review113286
-----------------------------------------------------------
On Jan. 8, 2016, 12:58 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40975/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2016, 12:58 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Document that libprocess ignores SIGPIPE.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/README.md 6a47f6772bb7a74af368ed970af0f1c154a070e3
>
> Diff: https://reviews.apache.org/r/40975/diff/
>
>
> Testing
> -------
>
> None.
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 40975: Document that libprocess ignores SIGPIPE
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40975/#review113286
-----------------------------------------------------------
Bad patch!
Reviews applied: [40975]
Failed command: ./support/apply-review.sh -n -r 40975
Error:
2016-01-07 18:32:55 URL:https://reviews.apache.org/r/40975/diff/raw/ [1164/1164] -> "40975.patch" [1]
No files to lint
Error: Commit message summary (the first line) must end in a period.
- Mesos ReviewBot
On Jan. 7, 2016, 5:30 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40975/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2016, 5:30 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Document that libprocess ignores SIGPIPE.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/README.md 6a47f6772bb7a74af368ed970af0f1c154a070e3
>
> Diff: https://reviews.apache.org/r/40975/diff/
>
>
> Testing
> -------
>
> None.
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 40975: Document that libprocess ignores SIGPIPE
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40975/
-----------------------------------------------------------
(Updated Jan. 7, 2016, 5:30 p.m.)
Review request for mesos and Ben Mahler.
Repository: mesos
Description
-------
Document that libprocess ignores SIGPIPE.
Diffs (updated)
-----
3rdparty/libprocess/README.md 6a47f6772bb7a74af368ed970af0f1c154a070e3
Diff: https://reviews.apache.org/r/40975/diff/
Testing
-------
None.
Thanks,
James Peach
Re: Review Request 40975: Document that libprocess ignores SIGPIPE
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40975/
-----------------------------------------------------------
(Updated Jan. 4, 2016, 4:31 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Updated with review feedback.
Repository: mesos
Description
-------
Document that libprocess ignores SIGPIPE.
Diffs (updated)
-----
3rdparty/libprocess/README.md 6a47f6772bb7a74af368ed970af0f1c154a070e3
Diff: https://reviews.apache.org/r/40975/diff/
Testing
-------
None.
Thanks,
James Peach
Re: Review Request 40975: Document that libprocess ignores SIGPIPE
Posted by James Peach <jp...@apache.org>.
> On Dec. 29, 2015, 7:32 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/README.md, lines 536-544
> > <https://reviews.apache.org/r/40975/diff/1/?file=1153951#file1153951line536>
> >
> > Hm.. since this document is about programming, do we need to say 'programming notes'? Or is 'notes' enough?
> >
> > It would be nice to also explain why we do this.
Updated.
- James
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40975/#review112206
-----------------------------------------------------------
On Jan. 4, 2016, 4:31 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40975/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2016, 4:31 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Document that libprocess ignores SIGPIPE.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/README.md 6a47f6772bb7a74af368ed970af0f1c154a070e3
>
> Diff: https://reviews.apache.org/r/40975/diff/
>
>
> Testing
> -------
>
> None.
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 40975: Document that libprocess ignores SIGPIPE
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40975/#review112206
-----------------------------------------------------------
3rdparty/libprocess/README.md (lines 536 - 544)
<https://reviews.apache.org/r/40975/#comment172546>
Hm.. since this document is about programming, do we need to say 'programming notes'? Or is 'notes' enough?
It would be nice to also explain why we do this.
- Ben Mahler
On Dec. 4, 2015, 5:33 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40975/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2015, 5:33 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Document that libprocess ignores SIGPIPE.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/README.md c3f309a7dc1c94882c4cc97eeaf0736c2fca0ba5
>
> Diff: https://reviews.apache.org/r/40975/diff/
>
>
> Testing
> -------
>
> None.
>
>
> Thanks,
>
> James Peach
>
>