You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/09/03 09:32:00 UTC

[jira] [Updated] (FLINK-10235) KafkaTableSourceSinkFactoryBase#getFlinkKafkaPartitioner does not compile with Java 9

     [ https://issues.apache.org/jira/browse/FLINK-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ASF GitHub Bot updated FLINK-10235:
-----------------------------------
    Labels: pull-request-available  (was: )

> KafkaTableSourceSinkFactoryBase#getFlinkKafkaPartitioner does not compile with Java 9
> -------------------------------------------------------------------------------------
>
>                 Key: FLINK-10235
>                 URL: https://issues.apache.org/jira/browse/FLINK-10235
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API &amp; SQL
>    Affects Versions: 1.7.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>
> The method compilation fails on java 9. The problem is that the {{CONNECTOR_SINK_PARTITIONER_VALUE_CUSTOM}} branch returns an {{Optional<Class<? extends FlinkKafkaPartitioner>>}}, but the method requires a {{Optional<FlinkKafkaPartitioner<Row>>}}.
> {code}
> private Optional<FlinkKafkaPartitioner<Row>> getFlinkKafkaPartitioner(DescriptorProperties descriptorProperties) {
> 	return descriptorProperties
> 		.getOptionalString(CONNECTOR_SINK_PARTITIONER)
> 		.flatMap((String partitionerString) -> {
> 			switch (partitionerString) {
> 				case CONNECTOR_SINK_PARTITIONER_VALUE_FIXED:
> 					return Optional.of(new FlinkFixedPartitioner<>());
> 				case CONNECTOR_SINK_PARTITIONER_VALUE_ROUND_ROBIN:
> 					return Optional.empty();
> 				case CONNECTOR_SINK_PARTITIONER_VALUE_CUSTOM:
> 					final Class<? extends FlinkKafkaPartitioner> partitionerClass =
> 						descriptorProperties.getClass(CONNECTOR_SINK_PARTITIONER_CLASS, FlinkKafkaPartitioner.class);
> 					return Optional.of(InstantiationUtil.instantiate(partitionerClass));
> 				default:
> 					throw new TableException("Unsupported sink partitioner. Validator should have checked that.");
> 			}
> 		});
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)