You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2026/10/04 19:40:35 UTC
[PR] ci: check licenses on release source tarball [datafusion-comet]
andygrove opened a new pull request, #6639:
URL: https://github.com/apache/datafusion-comet/pull/6639
## Which issue does this PR close?
Closes #6638.
## Rationale for this change
CI and the release process currently maintain separate Apache RAT configurations. The Maven plugin scans the working tree with one exclusion list, while source releases run the standalone checker against the release tarball with another. The two paths can drift, and CI does not validate the exact artifact that will ship.
The Maven path also requires bootstrapping Maven and downloading the plugin dependencies in the preflight job. Recent CI runs spend 21-29 seconds on that bootstrap plus RAT check, while the canonical tarball check takes about 5 seconds locally including archive creation.
## What changes are included in this PR?
- Create source tarballs through a shared helper used by both CI and the release script.
- Run the release RAT script against that tarball in preflight and remove the Maven RAT plugin/configuration.
- Harden the release RAT script so missing inputs, download failures, RAT failures, and report parser failures cannot produce a false green result.
- Add `make rat` for running the canonical check locally against `HEAD`.
- Remove the now-unnecessary Maven bootstrap from preflight and update the CI documentation.
## How are these changes tested?
- `make rat`
- `python3 dev/ci/check-ci-config.py`
- `./mvnw -B -N validate`
- `shellcheck dev/release/run-rat.sh dev/release/check-rat.sh dev/release/create-source-tarball.sh dev/release/create-tarball.sh`
- `prettier --check .github/workflows/README.md`
- `bash -n` for the modified and added release scripts
- Verified `run-rat.sh` exits nonzero for both a missing tarball and a tarball containing an unlicensed file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] ci: check licenses on release source tarball [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove merged PR #6639:
URL: https://github.com/apache/datafusion-comet/pull/6639
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org