You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by wy...@apache.org on 2026/08/20 06:18:55 UTC
(maka) branch fix/steering-composer-completion-fence created (now a0190863f)
This is an automated email from the ASF dual-hosted git repository.
M4n5ter pushed a change to branch fix/steering-composer-completion-fence
in repository https://gitbox.apache.org/repos/asf/maka.git
at a0190863f test(desktop): isolate side-chat slash dispatch
This branch includes the following new commits:
new a0190863f test(desktop): isolate side-chat slash dispatch
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
(maka) 01/01: test(desktop): isolate side-chat slash dispatch
Posted by wy...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
M4n5ter pushed a commit to branch fix/steering-composer-completion-fence
in repository https://gitbox.apache.org/repos/asf/maka.git
commit a0190863f88cb423b9129dd697f636458273022f
Author: M4n5ter <m4...@gmail.com>
AuthorDate: Thu Aug 20 14:18:14 2026 +0800
test(desktop): isolate side-chat slash dispatch
The slash-command E2E chained an unrelated steering submission before exercising /side, creating a race against the composer's async draft settlement. Steering already has dedicated Desktop E2E coverage, so keep this scenario focused on the running-turn slash dispatch contract.
---
apps/desktop/e2e/slash-command-menu.spec.ts | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/apps/desktop/e2e/slash-command-menu.spec.ts b/apps/desktop/e2e/slash-command-menu.spec.ts
index 947782bc7..373c6c248 100644
--- a/apps/desktop/e2e/slash-command-menu.spec.ts
+++ b/apps/desktop/e2e/slash-command-menu.spec.ts
@@ -109,7 +109,7 @@ test('offers commands only for the first token and keeps explicit Skill queries
await expect(inlineMenu.getByRole('group', { name: '命令' })).toHaveCount(0);
});
-test('dispatches a staged slash command instead of steering it into a running turn', async ({
+test('dispatches /side instead of steering it into a running turn', async ({
invocableSkillsWindow: page,
}) => {
const composer = page.locator(COMPOSER_INPUT);
@@ -119,14 +119,6 @@ test('dispatches a staged slash command instead of steering it into a running tu
await expect(page.locator('.maka-user-message', { hasText: runningPrompt })).toBeVisible();
await expect(page.getByRole('button', { name: '停止' })).toBeVisible();
- await composer.fill('/compact explain');
- await expect(page.getByRole('button', { name: '插入消息' })).toBeVisible();
- await composer.press('Enter');
-
- // After the steering send the composer remounts. `fill('/')` can land
- // before the contentEditable is focused, so the `/` trigger never
- // populates. An empty command group then makes `/compact` look absent
- // and the `/side` click waits out the timeout.
await composer.click();
await composer.pressSequentially('/');
const menu = page.getByRole('listbox', { name: '命令和技能' });
@@ -142,6 +134,5 @@ test('dispatches a staged slash command instead of steering it into a running tu
await composer.press('Enter');
await expect(page.locator('.maka-quote-workbar-panel')).toHaveCount(1);
- await expect(page.getByText(/Acknowledged steering: \/compact explain/)).toBeVisible();
await page.getByRole('button', { name: '停止' }).click();
});
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org