[GitHub] [airflow] jedcunningham commented on a diff in pull request #34342: Chart: added basic support git-sync v4.0.0+

["jedcunningham (via GitHub)" <gi...@apache.org>]

jedcunningham commented on code in PR #34342:
URL: https://github.com/apache/airflow/pull/34342#discussion_r1337847432


##########
chart/templates/_helpers.yaml:
##########
@@ -198,51 +198,49 @@ If release name contains chart name it will be used as a full name.
   securityContext: {{- include "localContainerSecurityContext" .Values.dags.gitSync | nindent 4 }}
   env:
     {{- if .Values.dags.gitSync.sshKeySecret }}
-    - name: GIT_SSH_KEY_FILE
+    - name: GITSYNC_SSH_KEY_FILE
       value: "/etc/git-secret/ssh"
-    - name: GIT_SYNC_SSH
+    - name: GITSYNC_SSH
       value: "true"
     {{- if .Values.dags.gitSync.knownHosts }}
-    - name: GIT_KNOWN_HOSTS
+    - name: GITSYNC_SSH_KNOWN_HOSTS
       value: "true"
-    - name: GIT_SSH_KNOWN_HOSTS_FILE
+    - name: GITSYNC_SSH_KNOWN_HOSTS_FILE
       value: "/etc/git-secret/known_hosts"
     {{- else }}
-    - name: GIT_KNOWN_HOSTS
+    - name: GITSYNC_SSH_KNOWN_HOSTS
       value: "false"
     {{- end }}
     {{ else if .Values.dags.gitSync.credentialsSecret }}
-    - name: GIT_SYNC_USERNAME
+    - name: GITSYNC_USERNAME
       valueFrom:
         secretKeyRef:
           name: {{ .Values.dags.gitSync.credentialsSecret | quote }}
-          key: GIT_SYNC_USERNAME
-    - name: GIT_SYNC_PASSWORD
+          key: GITSYNC_USERNAME

Review Comment:
   No, we don't have to change the key in the secret, just the env var we are mounting it to (line 265). That makes it a non-breaking change. Alternatively, we could support both.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org