You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "xiaoxiang781216 (via GitHub)" <gi...@apache.org> on 2023/08/26 09:31:38 UTC
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #10408: libs/libc: Breakdown LIBC_BUILD_STRING into specific string operation…
xiaoxiang781216 commented on code in PR #10408:
URL: https://github.com/apache/nuttx/pull/10408#discussion_r1306388629
##########
libs/libc/machine/Kconfig:
##########
@@ -137,12 +137,179 @@ config LIBC_ARCH_ELF_64BIT
default n
depends on LIBC_ARCH_ELF
-config LIBC_PREVENT_STRING_KERNEL
+config LIBC_PREVENT_STRRCHR_KERNEL
Review Comment:
let's sort the new option
##########
libs/libc/libc.h:
##########
@@ -58,7 +58,27 @@
#if defined(CONFIG_BUILD_FLAT) || \
((!defined(CONFIG_LIBC_PREVENT_STRING_USER) && !defined(__KERNEL__)) || \
(!defined(CONFIG_LIBC_PREVENT_STRING_KERNEL) && defined(__KERNEL__)))
-# define LIBC_BUILD_STRING
Review Comment:
change individual option like this:
```
#if defined(CONFIG_BUILD_FLAT) || \
((!defined(CONFIG_LIBC_PREVENT_STRRCHR_USER) && !defined(__KERNEL__)) || \
(!defined(CONFIG_LIBC_PREVENT_STRRCHR_KERNEL) && defined(__KERNEL__)))
# define LIBC_BUILD_STRRCHR
#endif
```
##########
libs/libc/string/lib_vikmemcpy.c:
##########
@@ -64,7 +64,7 @@
#include "libc.h"
-#if !defined(CONFIG_LIBC_ARCH_MEMCPY) && defined(LIBC_BUILD_STRING)
+#if !defined(CONFIG_LIBC_ARCH_MEMCPY) && defined(LIBC_BUILD_VIKMEMCPY)
Review Comment:
```suggestion
#if !defined(CONFIG_LIBC_ARCH_MEMCPY) && defined(LIBC_BUILD_MEMCPY)
```
##########
libs/libc/machine/Kconfig:
##########
@@ -151,15 +318,325 @@ config LIBC_PREVENT_STRING_KERNEL
NuttX's software-defined version of the libc or arch-specific
assembly version is built instead.
-config LIBC_PREVENT_STRING_USER
Review Comment:
let's keep LIBC_PREVENT_STRING_USER and select LIBC_PREVENT_*_USER
##########
libs/libc/machine/Kconfig:
##########
@@ -137,12 +137,179 @@ config LIBC_ARCH_ELF_64BIT
default n
depends on LIBC_ARCH_ELF
-config LIBC_PREVENT_STRING_KERNEL
Review Comment:
let's keep LIBC_PREVENT_STRING_KERNEL and select LIBC_PREVENT_*_KERNEL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org