[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1443: feat(new_metrics): migrate replica-level metrics for pegasus_manual_compact_service

["acelyc111 (via GitHub)" <gi...@apache.org>]

acelyc111 commented on code in PR #1443:
URL: https://github.com/apache/incubator-pegasus/pull/1443#discussion_r1168630610


##########
src/utils/test/metrics_test.cpp:
##########
@@ -3195,4 +3232,6 @@ TEST_F(MetricVarTest, AutoLatencyMilliSeconds) { TEST_METRIC_VAR_AUTO_LATENCY(ms
 
 TEST_F(MetricVarTest, AutoLatencySeconds) { TEST_METRIC_VAR_AUTO_LATENCY(s, 1000 * 1000 * 1000); }
 
+TEST_F(MetricVarTest, AutoCount) { test_auto_count(); }

Review Comment:
   ```suggestion
   TEST_F(MetricVarTest, AutoCount) { ASSERT_NO_FATAL_FAILURE(test_auto_count()); }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org