[jira] [Work logged] (AVRO-1438) C# reader performance improvement

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/AVRO-1438?focusedWorklogId=742930&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-742930 ]

ASF GitHub Bot logged work on AVRO-1438:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/Mar/22 02:38
            Start Date: 17/Mar/22 02:38
    Worklog Time Spent: 10m 
      Work Description: KyleSchoonover opened a new pull request #1604:
URL: https://github.com/apache/avro/pull/1604


   The original intent of this improvement was to increase the performance of the Generic / Specific Reader classes in regards to RecordSchema.  I tested for both netcore 3.1 and .Net 6.0.  The performance increase is around 15% of netcore 3.1.  For .Net 6.0 it is around 7%.
   
   In addition, I tested with a hashset assuming multiple repeating records within a large schema, but it actually decreased performance.
   
   ### Jira
   
   - [ ] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"
     - https://issues.apache.org/jira/browse/AVRO-1438
   
   ### Tests
   
   - [ ] My PR does not need testing for this extremely good reason: Performance improvement.  Ran manually through perf test project
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 742930)
    Remaining Estimate: 0h
            Time Spent: 10m

> C# reader performance improvement
> ---------------------------------
>
>                 Key: AVRO-1438
>                 URL: https://issues.apache.org/jira/browse/AVRO-1438
>             Project: Apache Avro
>          Issue Type: Improvement
>          Components: csharp
>    Affects Versions: 1.7.5
>            Reporter: David Taylor
>            Priority: Minor
>         Attachments: RecordSchema.cs.diff
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> GenericReader/SpecificReader spend a lot of time comparing the reader/writer schema.  Remembering the last good match speeds things up about 15% in my tests using the avro.pref project for timings.  This does not impact the DatumReader implementation.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)