[GitHub] [superset] zuzana-vej commented on issue #10330: [SQL Lab] Add an alert in SQL Lab when results are limited

[GitBox <gi...@apache.org>]

zuzana-vej commented on issue #10330:
URL: https://github.com/apache/superset/issues/10330#issuecomment-776877611


   End user doesn't know about DISPLAY_MAX_ROW or SQL_MAX_ROW and there is nothing they can do (besides contacting the admin). Do we want to expose this level of detail to them?
   
   I think the messaging for when user limits in dropdown, or when user limits in query is great. When there is systems settings which admin (maintaining team) needs to config, I would think we can keep more generic message like one of these:
   
   - It appears that the number of rows displayed is limited to 1000 by system configuration. 
   - It appears that the number of rows displayed is limited to 1000 by system configuration. Contact your admin for more details.
   
   Also do we need to word "It appears"? Or can we just say "The number of rows displayed is limited to 1000 by system configuration." The "It appears" make is sounds like we are not sure whether that's the case (and if we aren't sure then it appears is correct, if we are sure that this is limiting factor and query would otherwise return more results, we don't need "it appears".


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org