You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by Stephen Darlington <st...@gridgain.com> on 2019/09/16 14:03:37 UTC
[IGNITE-9836] Invalid check of ea java versions
Hi,
Would someone mind taking a quick look at this ticket? Basically, a clean download of Ignite won’t start if the version of Java you’re using has a number like “java version "1.8.0_202-ea””. (This is the default if you get your JDK using Homebrew on a Mac.)
> https://issues.apache.org/jira/browse/IGNITE-9836 <https://issues.apache.org/jira/browse/IGNITE-9836>
This has been bugging me for ages and now that I look at it I find that there’s already a tiny, working patch available.
Regards,
Stephen
Re: [IGNITE-9836] Invalid check of ea java versions
Posted by Ilya Kasnacheev <il...@gmail.com>.
Hello!
Thank you, I have merged both.
Regards,
--
Ilya Kasnacheev
пт, 27 сент. 2019 г. в 14:36, Stephen Darlington <
stephen.darlington@gridgain.com>:
> Done: https://github.com/apache/ignite/pull/6920
>
> While we’re talking about the startup scripts…
> https://issues.apache.org/jira/browse/IGNITE-11856
>
> Regards,
> Stephen
>
> > On 26 Sep 2019, at 17:02, Ilya Kasnacheev <il...@gmail.com>
> wrote:
> >
> > Hello!
> >
> > Please do!
> >
> > Regards,
> > --
> > Ilya Kasnacheev
> >
> >
> > вт, 17 сент. 2019 г. в 11:13, Stephen Darlington <
> > stephen.darlington@gridgain.com>:
> >
> >> I can’t take any credit for the patch but if the original author has
> lost
> >> interest I’m happy to help push it through.
> >>
> >> Regards,
> >> Stephen
> >>
> >>> On 16 Sep 2019, at 19:31, Denis Magda <dm...@apache.org> wrote:
> >>>
> >>> Stephen,
> >>>
> >>> Thanks for sending the patch! Seems that Igniters are already actively
> >>> reviewing it in JIRA.
> >>>
> >>> -
> >>> Denis
> >>>
> >>>
> >>> On Mon, Sep 16, 2019 at 7:03 AM Stephen Darlington <
> >>> stephen.darlington@gridgain.com> wrote:
> >>>
> >>>> Hi,
> >>>>
> >>>> Would someone mind taking a quick look at this ticket? Basically, a
> >> clean
> >>>> download of Ignite won’t start if the version of Java you’re using
> has a
> >>>> number like “java version "1.8.0_202-ea””. (This is the default if you
> >> get
> >>>> your JDK using Homebrew on a Mac.)
> >>>>
> >>>>> https://issues.apache.org/jira/browse/IGNITE-9836 <
> >>>> https://issues.apache.org/jira/browse/IGNITE-9836>
> >>>>
> >>>> This has been bugging me for ages and now that I look at it I find
> that
> >>>> there’s already a tiny, working patch available.
> >>>>
> >>>> Regards,
> >>>> Stephen
> >>
> >>
> >>
>
>
>
Re: [IGNITE-9836] Invalid check of ea java versions
Posted by Stephen Darlington <st...@gridgain.com>.
Done: https://github.com/apache/ignite/pull/6920
While we’re talking about the startup scripts… https://issues.apache.org/jira/browse/IGNITE-11856
Regards,
Stephen
> On 26 Sep 2019, at 17:02, Ilya Kasnacheev <il...@gmail.com> wrote:
>
> Hello!
>
> Please do!
>
> Regards,
> --
> Ilya Kasnacheev
>
>
> вт, 17 сент. 2019 г. в 11:13, Stephen Darlington <
> stephen.darlington@gridgain.com>:
>
>> I can’t take any credit for the patch but if the original author has lost
>> interest I’m happy to help push it through.
>>
>> Regards,
>> Stephen
>>
>>> On 16 Sep 2019, at 19:31, Denis Magda <dm...@apache.org> wrote:
>>>
>>> Stephen,
>>>
>>> Thanks for sending the patch! Seems that Igniters are already actively
>>> reviewing it in JIRA.
>>>
>>> -
>>> Denis
>>>
>>>
>>> On Mon, Sep 16, 2019 at 7:03 AM Stephen Darlington <
>>> stephen.darlington@gridgain.com> wrote:
>>>
>>>> Hi,
>>>>
>>>> Would someone mind taking a quick look at this ticket? Basically, a
>> clean
>>>> download of Ignite won’t start if the version of Java you’re using has a
>>>> number like “java version "1.8.0_202-ea””. (This is the default if you
>> get
>>>> your JDK using Homebrew on a Mac.)
>>>>
>>>>> https://issues.apache.org/jira/browse/IGNITE-9836 <
>>>> https://issues.apache.org/jira/browse/IGNITE-9836>
>>>>
>>>> This has been bugging me for ages and now that I look at it I find that
>>>> there’s already a tiny, working patch available.
>>>>
>>>> Regards,
>>>> Stephen
>>
>>
>>
Re: [IGNITE-9836] Invalid check of ea java versions
Posted by Ilya Kasnacheev <il...@gmail.com>.
Hello!
Please do!
Regards,
--
Ilya Kasnacheev
вт, 17 сент. 2019 г. в 11:13, Stephen Darlington <
stephen.darlington@gridgain.com>:
> I can’t take any credit for the patch but if the original author has lost
> interest I’m happy to help push it through.
>
> Regards,
> Stephen
>
> > On 16 Sep 2019, at 19:31, Denis Magda <dm...@apache.org> wrote:
> >
> > Stephen,
> >
> > Thanks for sending the patch! Seems that Igniters are already actively
> > reviewing it in JIRA.
> >
> > -
> > Denis
> >
> >
> > On Mon, Sep 16, 2019 at 7:03 AM Stephen Darlington <
> > stephen.darlington@gridgain.com> wrote:
> >
> >> Hi,
> >>
> >> Would someone mind taking a quick look at this ticket? Basically, a
> clean
> >> download of Ignite won’t start if the version of Java you’re using has a
> >> number like “java version "1.8.0_202-ea””. (This is the default if you
> get
> >> your JDK using Homebrew on a Mac.)
> >>
> >>> https://issues.apache.org/jira/browse/IGNITE-9836 <
> >> https://issues.apache.org/jira/browse/IGNITE-9836>
> >>
> >> This has been bugging me for ages and now that I look at it I find that
> >> there’s already a tiny, working patch available.
> >>
> >> Regards,
> >> Stephen
>
>
>
Re: [IGNITE-9836] Invalid check of ea java versions
Posted by Stephen Darlington <st...@gridgain.com>.
I can’t take any credit for the patch but if the original author has lost interest I’m happy to help push it through.
Regards,
Stephen
> On 16 Sep 2019, at 19:31, Denis Magda <dm...@apache.org> wrote:
>
> Stephen,
>
> Thanks for sending the patch! Seems that Igniters are already actively
> reviewing it in JIRA.
>
> -
> Denis
>
>
> On Mon, Sep 16, 2019 at 7:03 AM Stephen Darlington <
> stephen.darlington@gridgain.com> wrote:
>
>> Hi,
>>
>> Would someone mind taking a quick look at this ticket? Basically, a clean
>> download of Ignite won’t start if the version of Java you’re using has a
>> number like “java version "1.8.0_202-ea””. (This is the default if you get
>> your JDK using Homebrew on a Mac.)
>>
>>> https://issues.apache.org/jira/browse/IGNITE-9836 <
>> https://issues.apache.org/jira/browse/IGNITE-9836>
>>
>> This has been bugging me for ages and now that I look at it I find that
>> there’s already a tiny, working patch available.
>>
>> Regards,
>> Stephen
Re: [IGNITE-9836] Invalid check of ea java versions
Posted by Denis Magda <dm...@apache.org>.
Stephen,
Thanks for sending the patch! Seems that Igniters are already actively
reviewing it in JIRA.
-
Denis
On Mon, Sep 16, 2019 at 7:03 AM Stephen Darlington <
stephen.darlington@gridgain.com> wrote:
> Hi,
>
> Would someone mind taking a quick look at this ticket? Basically, a clean
> download of Ignite won’t start if the version of Java you’re using has a
> number like “java version "1.8.0_202-ea””. (This is the default if you get
> your JDK using Homebrew on a Mac.)
>
> > https://issues.apache.org/jira/browse/IGNITE-9836 <
> https://issues.apache.org/jira/browse/IGNITE-9836>
>
> This has been bugging me for ages and now that I look at it I find that
> there’s already a tiny, working patch available.
>
> Regards,
> Stephen