[GitHub] [datasketches-memory] leerho commented on a change in pull request #155: Jdk17 panama

[GitBox <gi...@apache.org>]

leerho commented on a change in pull request #155:
URL: https://github.com/apache/datasketches-memory/pull/155#discussion_r750595453



##########
File path: datasketches-memory-java9/src/main/java/module-info.java
##########
@@ -22,5 +22,5 @@
     requires java.logging;
     requires jdk.unsupported;
 
-    exports org.apache.datasketches.memory;
+    exports org.apache.datasketches.memory.internal;

Review comment:
       The problem is that exporting org.apache.datasketches.memory throws an error because that package under java9 is empty.  We would have to insert either a dummy class or duplicate some class from java8 just so that it is not empty.  
   I changed it to -.internal to eliminate the error.   Perhaps the answer is to eliminate the export entirely.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org