You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by eymorale <gi...@git.apache.org> on 2015/10/29 19:57:47 UTC
[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...
GitHub user eymorale opened a pull request:
https://github.com/apache/cordova-lib/pull/334
CB-9901 cordova plugin search opens in a browser
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eymorale/cordova-lib CB-9901
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/334.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #334
----
commit d305c49c5fb63fa683aea6c0f3f68218bb907dbc
Author: Edna Morales <ed...@gmail.com>
Date: 2015-10-29T18:54:40Z
CB-9901 cordova plugin search opens in a browser
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...
Posted by eymorale <gi...@git.apache.org>.
Github user eymorale commented on the pull request:
https://github.com/apache/cordova-lib/pull/334#issuecomment-152611628
@omefire I've started a discussion thread for this on the dev list
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/334
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...
Posted by eymorale <gi...@git.apache.org>.
Github user eymorale commented on the pull request:
https://github.com/apache/cordova-lib/pull/334#issuecomment-152596207
Thanks @nikhilkh! I'll take a look at the jshint failure and fix it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/334#issuecomment-153214572
Lets merge this in after the 5.4.0 release
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...
Posted by TimBarham <gi...@git.apache.org>.
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/334#issuecomment-152612090
Are people likely to be doing a plugin search from a gulp script?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...
Posted by csantanapr <gi...@git.apache.org>.
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/334#issuecomment-152646051
I think is a nice feature to open the browser to a good spot on the wen to search for plugins applicable for cli use cases where people are running by hand when they get started to use the CLI. not applicable to unattended. The current form is just a mess of a UI/UX.
For scripting or unattended like gulp scripts I guess they can use npmsearh same way we are doing for the website plugin search.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/334#issuecomment-152566519
LGTM this is a good one to fix. There is a jshint failure though that you might want to fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...
Posted by omefire <gi...@git.apache.org>.
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/334#issuecomment-152610676
What about people who use Cordova-lib from gulp instead of the cli ?
Does it make sense to pop open a browser window ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...
Posted by eymorale <gi...@git.apache.org>.
Github user eymorale commented on the pull request:
https://github.com/apache/cordova-lib/pull/334#issuecomment-153361722
sounds good. thanks @stevengill
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org