You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/08/22 02:36:16 UTC

[GitHub] [calcite] danny0405 commented on a change in pull request #2108: [CALCITE-4172] Expand columnar identifiers before resolution (James Starr)

danny0405 commented on a change in pull request #2108:
URL: https://github.com/apache/calcite/pull/2108#discussion_r475035866



##########
File path: core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java
##########
@@ -4007,6 +4006,7 @@ protected void validateGroupClause(SqlSelect select) {
     }
     groupList = new SqlNodeList(expandedList, groupList.getParserPosition());
     select.setGroupBy(groupList);
+    inferUnknownTypes(unknownType, groupScope, groupList);
     for (SqlNode groupItem : expandedList) {

Review comment:
       Seems reasonable.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org