You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/11 01:47:24 UTC
[GitHub] [doris] AshinGau opened a new pull request, #15794: [bugfix](datetimev2) fix coredump when load datatime data to doris from parquet
AshinGau opened a new pull request, #15794:
URL: https://github.com/apache/doris/pull/15794
# Proposed changes
Issue Number: close #xxx
## Problem summary
`date_time_v2` will check scale when constructed datatimev2:
```
LOG(FATAL) << fmt::format("Scale {} is out of bounds", scale);
```
This [PR](https://github.com/apache/doris/pull/15510) has fixed this issue, but parquet does not use constructor to create `TypeDescriptor`, leading the `scale = -1` when reading datetimev2 data.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [x] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [x] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [x] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [x] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [x] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15794: [bugfix](datetimev2) fix coredump when load datatime data to doris from parquet
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15794:
URL: https://github.com/apache/doris/pull/15794#issuecomment-1378471069
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15794: [bugfix](datetimev2) fix coredump when load datatime data to doris from parquet
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15794:
URL: https://github.com/apache/doris/pull/15794#issuecomment-1378140185
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15794: [bugfix](datetimev2) fix coredump when load datatime data to doris from parquet
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15794:
URL: https://github.com/apache/doris/pull/15794#issuecomment-1378422457
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15794: [bugfix](datetimev2) fix coredump when load datatime data to doris from parquet
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15794:
URL: https://github.com/apache/doris/pull/15794#issuecomment-1378722967
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15794: [bugfix](datetimev2) fix coredump when load datatime data to doris from parquet
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15794:
URL: https://github.com/apache/doris/pull/15794#issuecomment-1378365229
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15794: [bugfix](datetimev2) fix coredump when load datatime data to doris from parquet
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15794:
URL: https://github.com/apache/doris/pull/15794#issuecomment-1379787961
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15794: [bugfix](datetimev2) fix coredump when load datatime data to doris from parquet
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15794:
URL: https://github.com/apache/doris/pull/15794#issuecomment-1380291177
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] wsjz commented on a diff in pull request #15794: [bugfix](datetimev2) fix coredump when load datatime data to doris from parquet
Posted by GitBox <gi...@apache.org>.
wsjz commented on code in PR #15794:
URL: https://github.com/apache/doris/pull/15794#discussion_r1066702030
##########
be/src/vec/exec/format/parquet/schema_desc.cpp:
##########
@@ -231,39 +232,41 @@ TypeDescriptor FieldDescriptor::convert_to_doris_type(tparquet::ConvertedType::t
TypeDescriptor type;
switch (convertedType) {
case tparquet::ConvertedType::type::UTF8:
- type.type = TYPE_STRING;
+ type = TypeDescriptor(TYPE_STRING);
break;
case tparquet::ConvertedType::type::DECIMAL:
- type.type = TYPE_DECIMALV2;
- type.precision = 27;
- type.scale = 9;
+ type = TypeDescriptor(TYPE_DECIMALV2);
Review Comment:
constuctor will set precision to -1 , so it will throw exception when DCHECK_NE(precision, -1) is somewhere
##########
be/src/vec/exec/format/parquet/schema_desc.cpp:
##########
@@ -231,39 +232,41 @@ TypeDescriptor FieldDescriptor::convert_to_doris_type(tparquet::ConvertedType::t
TypeDescriptor type;
switch (convertedType) {
case tparquet::ConvertedType::type::UTF8:
- type.type = TYPE_STRING;
+ type = TypeDescriptor(TYPE_STRING);
break;
case tparquet::ConvertedType::type::DECIMAL:
- type.type = TYPE_DECIMALV2;
- type.precision = 27;
- type.scale = 9;
+ type = TypeDescriptor(TYPE_DECIMALV2);
break;
case tparquet::ConvertedType::type::DATE:
- type.type = TYPE_DATEV2;
+ type = TypeDescriptor(TYPE_DATEV2);
break;
case tparquet::ConvertedType::type::TIME_MILLIS:
case tparquet::ConvertedType::type::TIME_MICROS:
- type.type = TYPE_TIMEV2;
+ type = TypeDescriptor(TYPE_TIMEV2);
break;
case tparquet::ConvertedType::type::TIMESTAMP_MILLIS:
case tparquet::ConvertedType::type::TIMESTAMP_MICROS:
- type.type = TYPE_DATETIMEV2;
+ type = TypeDescriptor(TYPE_DATETIMEV2);
Review Comment:
same as TYPE_DECIMALV2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15794: [bugfix](datetimev2) fix coredump when load datatime data to doris from parquet
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15794:
URL: https://github.com/apache/doris/pull/15794#issuecomment-1379802096
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15794: [bugfix](datetimev2) fix coredump when load datatime data to doris from parquet
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15794:
URL: https://github.com/apache/doris/pull/15794#issuecomment-1378477817
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.25 seconds
load time: 503 seconds
storage size: 17122796157 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230111094013_clickbench_pr_77629.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #15794: [bugfix](datetimev2) fix coredump when load datatime data to doris from parquet
Posted by GitBox <gi...@apache.org>.
morningman merged PR #15794:
URL: https://github.com/apache/doris/pull/15794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org