You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@royale.apache.org by GitBox <gi...@apache.org> on 2021/01/13 14:36:32 UTC
[GitHub] [royale-asjs] SemiConscious opened a new pull request #1054: Set AMF context to correct encoding
SemiConscious opened a new pull request #1054:
URL: https://github.com/apache/royale-asjs/pull/1054
This fix does two things:
1. the current code will probably crash if a read of an AMF0 encoded message is attempted, as the reader assumes AMF3, and nothing I can see changes that, including using the AMF0AMF3Context bead. This fix ensures that when the encoding type (0 or 3) is read from the message, the subsequent read is carried out using that encoding.
2. the second benefit is customer experience. Without the bead, the existing code outputs an error that gives no clue to the nature of the underlying problem - this is the reason I have gone down this particular rabbit hole. With this fix, if an AMF0 message is read, this error is output when reading AMF0: `AMF0 support is unimplemented by default, supported via bead`. With the bead in use, this fix does nothing beyond simply allowing the data to be read correctly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [royale-asjs] greg-dove merged pull request #1054: Set AMF context to correct encoding
Posted by GitBox <gi...@apache.org>.
greg-dove merged pull request #1054:
URL: https://github.com/apache/royale-asjs/pull/1054
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [royale-asjs] greg-dove commented on pull request #1054: Set AMF context to correct encoding
Posted by GitBox <gi...@apache.org>.
greg-dove commented on pull request #1054:
URL: https://github.com/apache/royale-asjs/pull/1054#issuecomment-759763748
Nice work - thanks again!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org