You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Mathieu Lalonde (JIRA)" <ji...@apache.org> on 2011/08/30 02:30:37 UTC

[jira] [Created] (CAMEL-4393) Camel :: Nagios unit test will break if exception is thrown during set up

Camel :: Nagios unit test will break if exception is thrown during set up
-------------------------------------------------------------------------

                 Key: CAMEL-4393
                 URL: https://issues.apache.org/jira/browse/CAMEL-4393
             Project: Camel
          Issue Type: Task
            Reporter: Mathieu Lalonde
            Priority: Minor
             Fix For: Future


The test classes swallow any exceptions thrown during setUp, log a warning and set flag indicating they can't run.
Test methods return successfully if the flag is set!  If an error is introduced during the setUp() phase, all tests will pass and we will be down to developer eye balls to spot the warning!

The simplest solution is to let the exception escape from setUp() which will count as a test error.



--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CAMEL-4393) Camel :: Nagios unit test will break if exception is thrown during set up

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093474#comment-13093474 ] 

Claus Ibsen commented on CAMEL-4393:
------------------------------------

This is okay as we have a farm of CI servers which would occasionally fail, and we frankly dont want the servers to fail from time to time, due a tiny issue with some "port number in use" issue with camel-nagios. So this is on purpose. 

> Camel :: Nagios unit test will break if exception is thrown during set up
> -------------------------------------------------------------------------
>
>                 Key: CAMEL-4393
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4393
>             Project: Camel
>          Issue Type: Task
>            Reporter: Mathieu Lalonde
>            Assignee: Mathieu Lalonde
>            Priority: Minor
>             Fix For: Future
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> The test classes swallow any exceptions thrown during setUp, log a warning and set flag indicating they can't run.
> Test methods return successfully if the flag is set!  If an error is introduced during the setUp() phase, all tests will pass and we will be down to developer eye balls to spot the warning!
> The simplest solution is to let the exception escape from setUp() which will count as a test error.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (CAMEL-4393) Camel :: Nagios unit test will break if exception is thrown during set up

Posted by "Mathieu Lalonde (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mathieu Lalonde reassigned CAMEL-4393:
--------------------------------------

    Assignee: Mathieu Lalonde

> Camel :: Nagios unit test will break if exception is thrown during set up
> -------------------------------------------------------------------------
>
>                 Key: CAMEL-4393
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4393
>             Project: Camel
>          Issue Type: Task
>            Reporter: Mathieu Lalonde
>            Assignee: Mathieu Lalonde
>            Priority: Minor
>             Fix For: Future
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> The test classes swallow any exceptions thrown during setUp, log a warning and set flag indicating they can't run.
> Test methods return successfully if the flag is set!  If an error is introduced during the setUp() phase, all tests will pass and we will be down to developer eye balls to spot the warning!
> The simplest solution is to let the exception escape from setUp() which will count as a test error.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (CAMEL-4393) Camel :: Nagios unit test will break if exception is thrown during set up

Posted by "Mathieu Lalonde (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mathieu Lalonde resolved CAMEL-4393.
------------------------------------

    Resolution: Won't Fix

> Camel :: Nagios unit test will break if exception is thrown during set up
> -------------------------------------------------------------------------
>
>                 Key: CAMEL-4393
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4393
>             Project: Camel
>          Issue Type: Task
>            Reporter: Mathieu Lalonde
>            Assignee: Mathieu Lalonde
>            Priority: Minor
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> The test classes swallow any exceptions thrown during setUp, log a warning and set flag indicating they can't run.
> Test methods return successfully if the flag is set!  If an error is introduced during the setUp() phase, all tests will pass and we will be down to developer eye balls to spot the warning!
> The simplest solution is to let the exception escape from setUp() which will count as a test error.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CAMEL-4393) Camel :: Nagios unit test will break if exception is thrown during set up

Posted by "Mathieu Lalonde (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mathieu Lalonde updated CAMEL-4393:
-----------------------------------

    Fix Version/s:     (was: Future)

I guess I jumped to conclusion too soon.  I'll make sure to take this into account for CAMEL-4332.

> Camel :: Nagios unit test will break if exception is thrown during set up
> -------------------------------------------------------------------------
>
>                 Key: CAMEL-4393
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4393
>             Project: Camel
>          Issue Type: Task
>            Reporter: Mathieu Lalonde
>            Assignee: Mathieu Lalonde
>            Priority: Minor
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> The test classes swallow any exceptions thrown during setUp, log a warning and set flag indicating they can't run.
> Test methods return successfully if the flag is set!  If an error is introduced during the setUp() phase, all tests will pass and we will be down to developer eye balls to spot the warning!
> The simplest solution is to let the exception escape from setUp() which will count as a test error.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira