You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/09/08 04:46:51 UTC
[GitHub] [dubbo-go-hessian2] AlexStocks commented on a change in pull request #234: fix fields name mismatch in Duration class
AlexStocks commented on a change in pull request #234:
URL: https://github.com/apache/dubbo-go-hessian2/pull/234#discussion_r484647319
##########
File path: java8_time/duration.go
##########
@@ -18,8 +18,8 @@
package java8_time
type Duration struct {
- Second int64 `hessian:"second"`
- Nano int32 `hessian:"nano"`
+ Seconds int64 `hessian:"seconds"`
Review comment:
I can not agree with u. Pls do not change the var name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org