You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Daniel Barclay <db...@maprtech.com> on 2015/04/10 03:32:38 UTC
Review Request 33043: DRILL-2613: 1-Hygiene/prep.: Split
DrillResultSet impl. vs. intf.; renaming.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33043/
-----------------------------------------------------------
Review request for drill, Mehant Baid and Parth Chandra.
Bugs: DRILL-2613
https://issues.apache.org/jira/browse/DRILL-2613
Repository: drill-git
Description
-------
Code "hygiene":
- Renamed parameter index to rowOffset, and documented it, in SqlAccessor.
- Renamed index to rowOffset in AbstractSqlAccessor and BoundCheckingAccessor too.
- Fixed a cast to DrillResultSet to be a ResultSet.unwrap(...) call.
Preparation: Split DrillResultSet into interface vs. implementation:
- Moved old implementation class org.apache.drill.jdbc.DrillResultSet
to new implementation class org.apache.drill.jdbc.impl.DrillResultSetImpl.
- Created new interface org.apache.drill.jdbc.DrillResultSet,
declaring method getQueryId(...).
- Relatedly, in nearby JDBC code:
- Renamed various references.
- Added some "public" qualifiers. Most are only for the interim until
DRILL-2089 (moving other implementation classes from org.apache.drill.jdbc
to org.apache.drill.jdbc.impl) is completed sufficiently. (See marking
with "DRILL-2089".)n
- (Files: old DrillResultSet, DrillResultSetImpl, new DrillResultSet;
DrillConnectionImpl, DrillCursor, DrillJdbc41Factory, MetaImpl;
JdbcTestQueryBase.)
Diffs
-----
exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/AbstractSqlAccessor.java 1605c7d
exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/BoundCheckingAccessor.java c8d6cc7
exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/SqlAccessor.java 6007bf4
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java 170495e
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillCursor.java 3b38a09
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillJdbc41Factory.java 4da26e9
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java 74900bc
exec/jdbc/src/main/java/org/apache/drill/jdbc/MetaImpl.java 4ff626e
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/JdbcTestQueryBase.java 4fec567
Diff: https://reviews.apache.org/r/33043/diff/
Testing
-------
Ran existing tests.
Thanks,
Daniel Barclay
Re: Review Request 33043: DRILL-2613: 1-Hygiene/prep.: Split
DrillResultSet impl. vs. intf.; renaming.
Posted by Daniel Barclay <db...@maprtech.com>.
> On April 10, 2015, 6:25 p.m., Parth Chandra wrote:
> > What did we gain by creating a new interface? Isn't ResultSet already the interface that DrillResultSet implements?
Generally, see https://issues.apache.org/jira/browse/DRILL-2089.
Specifically for DRILL-2613's changes:
We gained having Drill's extension of ResultSet defined by an interface that lists only the intended public aspects (the getQueryId method, the behavior of unwrap, etc.) rather by a class that has not just that getQueryId method but also has implementation details.
We gained a place to put Drill-specific documentation of Drill-specific behavior of its implementation of ResultSet methods. See the numeric-conversion documentation on getXxx(...) column-accessor methods and unwrap, etc., in the second-half patch for DRILL-2616 (https://reviews.apache.org/r/33044/).
- Daniel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33043/#review79733
-----------------------------------------------------------
On April 10, 2015, 1:32 a.m., Daniel Barclay wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33043/
> -----------------------------------------------------------
>
> (Updated April 10, 2015, 1:32 a.m.)
>
>
> Review request for drill, Mehant Baid and Parth Chandra.
>
>
> Bugs: DRILL-2613
> https://issues.apache.org/jira/browse/DRILL-2613
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Code "hygiene":
> - Renamed parameter index to rowOffset, and documented it, in SqlAccessor.
> - Renamed index to rowOffset in AbstractSqlAccessor and BoundCheckingAccessor too.
> - Fixed a cast to DrillResultSet to be a ResultSet.unwrap(...) call.
>
> Preparation: Split DrillResultSet into interface vs. implementation:
> - Moved old implementation class org.apache.drill.jdbc.DrillResultSet
> to new implementation class org.apache.drill.jdbc.impl.DrillResultSetImpl.
> - Created new interface org.apache.drill.jdbc.DrillResultSet,
> declaring method getQueryId(...).
> - Relatedly, in nearby JDBC code:
> - Renamed various references.
> - Added some "public" qualifiers. Most are only for the interim until
> DRILL-2089 (moving other implementation classes from org.apache.drill.jdbc
> to org.apache.drill.jdbc.impl) is completed sufficiently. (See marking
> with "DRILL-2089".)n
> - (Files: old DrillResultSet, DrillResultSetImpl, new DrillResultSet;
> DrillConnectionImpl, DrillCursor, DrillJdbc41Factory, MetaImpl;
> JdbcTestQueryBase.)
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/AbstractSqlAccessor.java 1605c7d
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/BoundCheckingAccessor.java c8d6cc7
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/SqlAccessor.java 6007bf4
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java 170495e
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillCursor.java 3b38a09
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillJdbc41Factory.java 4da26e9
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java 74900bc
> exec/jdbc/src/main/java/org/apache/drill/jdbc/MetaImpl.java 4ff626e
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java PRE-CREATION
> exec/jdbc/src/test/java/org/apache/drill/jdbc/test/JdbcTestQueryBase.java 4fec567
>
> Diff: https://reviews.apache.org/r/33043/diff/
>
>
> Testing
> -------
>
> Ran existing tests.
>
>
> Thanks,
>
> Daniel Barclay
>
>
Re: Review Request 33043: DRILL-2613: 1-Hygiene/prep.: Split
DrillResultSet impl. vs. intf.; renaming.
Posted by Parth Chandra <pc...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33043/#review79733
-----------------------------------------------------------
What did we gain by creating a new interface? Isn't ResultSet already the interface that DrillResultSet implements?
- Parth Chandra
On April 10, 2015, 1:32 a.m., Daniel Barclay wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33043/
> -----------------------------------------------------------
>
> (Updated April 10, 2015, 1:32 a.m.)
>
>
> Review request for drill, Mehant Baid and Parth Chandra.
>
>
> Bugs: DRILL-2613
> https://issues.apache.org/jira/browse/DRILL-2613
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Code "hygiene":
> - Renamed parameter index to rowOffset, and documented it, in SqlAccessor.
> - Renamed index to rowOffset in AbstractSqlAccessor and BoundCheckingAccessor too.
> - Fixed a cast to DrillResultSet to be a ResultSet.unwrap(...) call.
>
> Preparation: Split DrillResultSet into interface vs. implementation:
> - Moved old implementation class org.apache.drill.jdbc.DrillResultSet
> to new implementation class org.apache.drill.jdbc.impl.DrillResultSetImpl.
> - Created new interface org.apache.drill.jdbc.DrillResultSet,
> declaring method getQueryId(...).
> - Relatedly, in nearby JDBC code:
> - Renamed various references.
> - Added some "public" qualifiers. Most are only for the interim until
> DRILL-2089 (moving other implementation classes from org.apache.drill.jdbc
> to org.apache.drill.jdbc.impl) is completed sufficiently. (See marking
> with "DRILL-2089".)n
> - (Files: old DrillResultSet, DrillResultSetImpl, new DrillResultSet;
> DrillConnectionImpl, DrillCursor, DrillJdbc41Factory, MetaImpl;
> JdbcTestQueryBase.)
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/AbstractSqlAccessor.java 1605c7d
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/BoundCheckingAccessor.java c8d6cc7
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/SqlAccessor.java 6007bf4
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java 170495e
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillCursor.java 3b38a09
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillJdbc41Factory.java 4da26e9
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java 74900bc
> exec/jdbc/src/main/java/org/apache/drill/jdbc/MetaImpl.java 4ff626e
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java PRE-CREATION
> exec/jdbc/src/test/java/org/apache/drill/jdbc/test/JdbcTestQueryBase.java 4fec567
>
> Diff: https://reviews.apache.org/r/33043/diff/
>
>
> Testing
> -------
>
> Ran existing tests.
>
>
> Thanks,
>
> Daniel Barclay
>
>
Re: Review Request 33043: DRILL-2613: 1-Hygiene/prep.: Split
DrillResultSet impl. vs. intf.; renaming.
Posted by Parth Chandra <pc...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33043/#review79891
-----------------------------------------------------------
Ship it!
Ship It!
- Parth Chandra
On April 12, 2015, 2:21 a.m., Daniel Barclay wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33043/
> -----------------------------------------------------------
>
> (Updated April 12, 2015, 2:21 a.m.)
>
>
> Review request for drill, Mehant Baid and Parth Chandra.
>
>
> Bugs: DRILL-2613
> https://issues.apache.org/jira/browse/DRILL-2613
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Code "hygiene":
> - Renamed parameter index to rowOffset, and documented it, in SqlAccessor.
> - Renamed index to rowOffset in AbstractSqlAccessor and BoundCheckingAccessor too.
> - Fixed a cast to DrillResultSet to be a ResultSet.unwrap(...) call.
>
> Preparation: Split DrillResultSet into interface vs. implementation:
> - Moved old implementation class org.apache.drill.jdbc.DrillResultSet
> to new implementation class org.apache.drill.jdbc.impl.DrillResultSetImpl.
> - Created new interface org.apache.drill.jdbc.DrillResultSet,
> declaring method getQueryId(...).
> - Relatedly, in nearby JDBC code:
> - Renamed various references.
> - Added some "public" qualifiers. Most are only for the interim until
> DRILL-2089 (moving other implementation classes from org.apache.drill.jdbc
> to org.apache.drill.jdbc.impl) is completed sufficiently. (See marking
> with "DRILL-2089".)n
> - (Files: old DrillResultSet, DrillResultSetImpl, new DrillResultSet;
> DrillConnectionImpl, DrillCursor, DrillJdbc41Factory, MetaImpl;
> JdbcTestQueryBase.)
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/codegen/templates/SqlAccessors.java c0ece9b
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/AbstractSqlAccessor.java 1605c7d
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/BoundCheckingAccessor.java c8d6cc7
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/GenericAccessor.java adee171
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/InvalidAccessException.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/SqlAccessor.java 6007bf4
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillAccessorList.java ccf2658
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java 74900bc
> exec/jdbc/src/main/java/org/apache/drill/jdbc/SQLConversionException.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/SQLConversionOverflowException.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/TypeConvertingSqlAccessor.java PRE-CREATION
> exec/jdbc/src/test/java/org/apache/drill/jdbc/ResultSetGetMethodConversionsTest.java PRE-CREATION
> exec/jdbc/src/test/java/org/apache/drill/jdbc/impl/TypeConvertingSqlAccessorTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33043/diff/
>
>
> Testing
> -------
>
> Ran existing tests.
>
>
> Thanks,
>
> Daniel Barclay
>
>
Re: Review Request 33043: DRILL-2613: 1-Hygiene/prep.: Split
DrillResultSet impl. vs. intf.; renaming.
Posted by Daniel Barclay <db...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33043/
-----------------------------------------------------------
(Updated April 12, 2015, 2:21 a.m.)
Review request for drill, Mehant Baid and Parth Chandra.
Bugs: DRILL-2613
https://issues.apache.org/jira/browse/DRILL-2613
Repository: drill-git
Description
-------
Code "hygiene":
- Renamed parameter index to rowOffset, and documented it, in SqlAccessor.
- Renamed index to rowOffset in AbstractSqlAccessor and BoundCheckingAccessor too.
- Fixed a cast to DrillResultSet to be a ResultSet.unwrap(...) call.
Preparation: Split DrillResultSet into interface vs. implementation:
- Moved old implementation class org.apache.drill.jdbc.DrillResultSet
to new implementation class org.apache.drill.jdbc.impl.DrillResultSetImpl.
- Created new interface org.apache.drill.jdbc.DrillResultSet,
declaring method getQueryId(...).
- Relatedly, in nearby JDBC code:
- Renamed various references.
- Added some "public" qualifiers. Most are only for the interim until
DRILL-2089 (moving other implementation classes from org.apache.drill.jdbc
to org.apache.drill.jdbc.impl) is completed sufficiently. (See marking
with "DRILL-2089".)n
- (Files: old DrillResultSet, DrillResultSetImpl, new DrillResultSet;
DrillConnectionImpl, DrillCursor, DrillJdbc41Factory, MetaImpl;
JdbcTestQueryBase.)
Diffs (updated)
-----
exec/java-exec/src/main/codegen/templates/SqlAccessors.java c0ece9b
exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/AbstractSqlAccessor.java 1605c7d
exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/BoundCheckingAccessor.java c8d6cc7
exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/GenericAccessor.java adee171
exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/InvalidAccessException.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/SqlAccessor.java 6007bf4
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillAccessorList.java ccf2658
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java 74900bc
exec/jdbc/src/main/java/org/apache/drill/jdbc/SQLConversionException.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/SQLConversionOverflowException.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/TypeConvertingSqlAccessor.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/ResultSetGetMethodConversionsTest.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/impl/TypeConvertingSqlAccessorTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/33043/diff/
Testing
-------
Ran existing tests.
Thanks,
Daniel Barclay
Re: Review Request 33043: DRILL-2613: 1-Hygiene/prep.: Split
DrillResultSet impl. vs. intf.; renaming.
Posted by Daniel Barclay <db...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33043/
-----------------------------------------------------------
(Updated April 12, 2015, 2:15 a.m.)
Review request for drill, Mehant Baid and Parth Chandra.
Bugs: DRILL-2613
https://issues.apache.org/jira/browse/DRILL-2613
Repository: drill-git
Description
-------
Code "hygiene":
- Renamed parameter index to rowOffset, and documented it, in SqlAccessor.
- Renamed index to rowOffset in AbstractSqlAccessor and BoundCheckingAccessor too.
- Fixed a cast to DrillResultSet to be a ResultSet.unwrap(...) call.
Preparation: Split DrillResultSet into interface vs. implementation:
- Moved old implementation class org.apache.drill.jdbc.DrillResultSet
to new implementation class org.apache.drill.jdbc.impl.DrillResultSetImpl.
- Created new interface org.apache.drill.jdbc.DrillResultSet,
declaring method getQueryId(...).
- Relatedly, in nearby JDBC code:
- Renamed various references.
- Added some "public" qualifiers. Most are only for the interim until
DRILL-2089 (moving other implementation classes from org.apache.drill.jdbc
to org.apache.drill.jdbc.impl) is completed sufficiently. (See marking
with "DRILL-2089".)n
- (Files: old DrillResultSet, DrillResultSetImpl, new DrillResultSet;
DrillConnectionImpl, DrillCursor, DrillJdbc41Factory, MetaImpl;
JdbcTestQueryBase.)
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/AbstractSqlAccessor.java 1605c7d
exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/BoundCheckingAccessor.java c8d6cc7
exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/SqlAccessor.java 6007bf4
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java 170495e
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillCursor.java 3b38a09
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillJdbc41Factory.java 4da26e9
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java 74900bc
exec/jdbc/src/main/java/org/apache/drill/jdbc/MetaImpl.java 4ff626e
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java PRE-CREATION
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/JdbcTestQueryBase.java 4fec567
Diff: https://reviews.apache.org/r/33043/diff/
Testing
-------
Ran existing tests.
Thanks,
Daniel Barclay