You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "haifxu (via GitHub)" <gi...@apache.org> on 2023/04/27 09:30:12 UTC
[GitHub] [inlong] haifxu opened a new pull request, #7944: [INLONG-7941][Manager][Dashborad] Add param to distinguish lightweight
haifxu opened a new pull request, #7944:
URL: https://github.com/apache/inlong/pull/7944
### Prepare a Pull Request
- Fixes #7941
### Motivation
1. We need to distinguish lightweight tasks when querying groups.
### Modifications
1. Add `lightweight` param.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] fuweng11 commented on a diff in pull request #7944: [INLONG-7941][Manager][Dashborad] Add param to distinguish lightweight
Posted by "fuweng11 (via GitHub)" <gi...@apache.org>.
fuweng11 commented on code in PR #7944:
URL: https://github.com/apache/inlong/pull/7944#discussion_r1179884219
##########
inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/InlongGroupController.java:
##########
@@ -88,9 +90,12 @@ public Response<InlongGroupInfo> get(@PathVariable String groupId) {
@RequestMapping(value = "/group/countByStatus", method = RequestMethod.GET)
@ApiOperation(value = "Count inlong group status for current user")
- public Response<InlongGroupCountResponse> countGroupByUser() {
+ @ApiImplicitParams({
Review Comment:
No need `@ApiImplicitParams`, just use `@ApiImplicitParam`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #7944: [INLONG-7941][Manager][Dashborad] Add param to distinguish lightweight
Posted by "healchow (via GitHub)" <gi...@apache.org>.
healchow commented on code in PR #7944:
URL: https://github.com/apache/inlong/pull/7944#discussion_r1179053366
##########
inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/InlongGroupController.java:
##########
@@ -88,9 +90,12 @@ public Response<InlongGroupInfo> get(@PathVariable String groupId) {
@RequestMapping(value = "/group/countByStatus", method = RequestMethod.GET)
@ApiOperation(value = "Count inlong group status for current user")
- public Response<InlongGroupCountResponse> countGroupByUser() {
+ @ApiImplicitParams({
+ @ApiImplicitParam(name = "lightweight", dataTypeClass = Integer.class, required = true)
Review Comment:
Please do not add `required = true`, and suggest adding one default value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #7944: [INLONG-7941][Manager][Dashborad] Add param to distinguish lightweight
Posted by "healchow (via GitHub)" <gi...@apache.org>.
healchow commented on code in PR #7944:
URL: https://github.com/apache/inlong/pull/7944#discussion_r1179054093
##########
inlong-manager/manager-dao/src/main/resources/mappers/InlongGroupEntityMapper.xml:
##########
@@ -98,6 +98,7 @@
select count(*) as total, status
from inlong_group
where is_deleted = 0
+ and lightweight = #{lightweight,jdbcType=TINYINT}
Review Comment:
Suggest check before using it:
```sql
<if test="lightweight != null">
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #7944: [INLONG-7941][Manager][Dashborad] Add param to distinguish lightweight
Posted by "healchow (via GitHub)" <gi...@apache.org>.
healchow commented on code in PR #7944:
URL: https://github.com/apache/inlong/pull/7944#discussion_r1180062892
##########
inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/InlongGroupController.java:
##########
@@ -88,9 +89,10 @@ public Response<InlongGroupInfo> get(@PathVariable String groupId) {
@RequestMapping(value = "/group/countByStatus", method = RequestMethod.GET)
@ApiOperation(value = "Count inlong group status for current user")
- public Response<InlongGroupCountResponse> countGroupByUser() {
+ @ApiImplicitParam(name = "lightweight", dataTypeClass = Integer.class, defaultValue = "0")
+ public Response<InlongGroupCountResponse> countGroupByUser(@RequestParam Integer lightweight) {
Review Comment:
-> `@RequestParam(required = false)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #7944: [INLONG-7941][Manager][Dashborad] Add param to distinguish lightweight
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang merged PR #7944:
URL: https://github.com/apache/inlong/pull/7944
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org